changed color of shortcut "Add New" #335

mienaiyami · Jan 21, 2024 · 40d7657 · 40d7657
1 parent d5c65d9
commit 40d7657
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 13 deletions.
diff --git a/src/renderer/Components/Settings.tsx b/src/renderer/Components/Settings.tsx
@@ -1596,7 +1596,7 @@ const Settings = (): ReactElement => {
                         </div>
                         <div className={`tab ${currentTab === TAB_INFO.shortcutKeys[0] ? "selected " : ""}`}>
                             {/* <h1>Shortcut Keys</h1> */}
-                            <Shortcuts scrollIntoView={scrollIntoView} settingContRef={settingContRef} />
+                            <Shortcuts scrollIntoView={scrollIntoView} />
                         </div>
                         <div className={`tab ${currentTab === TAB_INFO.makeTheme[0] ? "selected " : ""}`}>
                             <ThemeCont />

diff --git a/src/renderer/Components/settings/Shortcuts.tsx b/src/renderer/Components/settings/Shortcuts.tsx
@@ -45,18 +45,11 @@ const ShortcutInput = ({ command }: { command: ShortcutCommands }) => {
                     value={""}
                     onKeyDown={(e) => {
                         e.stopPropagation();
-                        if (!["Tab", "Escape", "Escape"].includes(e.key)) e.preventDefault();
+                        if (!["Tab", "Escape"].includes(e.key)) e.preventDefault();
                     }}
                     onKeyUp={(e) => {
                         e.preventDefault();
                         e.stopPropagation();
-                        // if (["Control", "Shift", "Alt", "Tab", "Backspace"].includes(e.key)) return;
-                        // settingContRef.current?.focus();
-                        // if (e.key === "Backspace") {
-                        //     window.logger.log(`Deleting shortcut ${shortcuts[i].command}.${which}`);
-                        //     dispatch(setShortcuts({ index: i, key: "", which }));
-                        //     return;
-                        // }
 
                         const newKey = window.keyFormatter(e.nativeEvent);
                         if (newKey === "") return;
@@ -95,10 +88,10 @@ const ShortcutInput = ({ command }: { command: ShortcutCommands }) => {
 };
 
 const Shortcuts = ({
-    settingContRef,
+    // settingContRef,
     scrollIntoView,
 }: {
-    settingContRef: React.RefObject<HTMLDivElement>;
+    // settingContRef: React.RefObject<HTMLDivElement>;
     scrollIntoView: (
         elementQuery: string,
         tab: "settings" | "shortcutKeys" | "makeTheme" | "about" | "extras"

diff --git a/src/renderer/styles/index.scss b/src/renderer/styles/index.scss
@@ -1886,10 +1886,13 @@
                                 }
                             }
                             .addNewKey {
-                                min-width: 6em;
-                                width: 6em;
+                                min-width: 7em;
+                                width: 7em;
                                 font-size: 0.9em;
                                 text-align: center;
+                                &::placeholder {
+                                    opacity: 1;
+                                }
                             }
                             div.keyDisplay {
                                 display: flex;