Improve handling of query string when uploading from URL

Closes refile#243

lib/refile/attacher.rb

@@ -102,7 +102,7 @@ def download(url)
         response = RestClient::Request.new(method: :get, url: url, raw_response: true).execute
         @metadata = {
           size: response.file.size,
-          filename: ::File.basename(url),
+          filename: URI.parse(url).path.split("/").last,
           content_type: response.headers[:content_type]
         }
         if valid?

spec/refile/features/normal_upload_spec.rb

@@ -119,7 +119,9 @@
   end
 
   scenario "Upload a file from a remote URL" do
-    stub_request(:get, "http://www.example.com/some_file").to_return(
+    url = "http://www.example.com/foo/bar/some_file.png?some-query-string=true"
+
+    stub_request(:get, url).to_return(
       status: 200,
       body: "abc",
       headers: {
@@ -130,13 +132,13 @@
 
     visit "/normal/posts/new"
     fill_in "Title", with: "A cool post"
-    fill_in "Remote document url", with: "http://www.example.com/some_file"
+    fill_in "Remote document url", with: url
     click_button "Create"
 
     expect(page).to have_selector("h1", text: "A cool post")
     expect(download_link("Document")).to eq("abc")
     expect(page).to have_selector(".content-type", text: "image/png")
     expect(page).to have_selector(".size", text: "3")
-    expect(page).to have_selector(".filename", text: "some_file")
+    expect(page).to have_selector(".filename", text: "some_file.png", exact: true)
   end
 end