Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory leak in settings indicators #236417

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: memory leak in settings indicators #236417

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
56aec5e
fix: memory leak in settings indicators
SimonSiefke Dec 17, 2024
9124c45
fix: memory leak in settings indicators
SimonSiefke Dec 17, 2024
a42485b
undo change
SimonSiefke Dec 17, 2024
fed530b
undo change
SimonSiefke Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/preferences/browser/settingsEditorSettingIndicators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ export class SettingsTreeIndicatorsLabel implements IDisposable {
}

updateScopeOverrides(element: SettingsTreeSettingElement, onDidClickOverrideElement: Emitter<ISettingOverrideClickEvent>, onApplyFilter: Emitter<string>) {
this.scopeOverridesIndicator.disposables.clear();
this.scopeOverridesIndicator.element.innerText = '';
this.scopeOverridesIndicator.element.style.display = 'none';
this.scopeOverridesIndicator.focusElement = this.scopeOverridesIndicator.element;
Expand Down Expand Up @@ -409,7 +410,6 @@ export class SettingsTreeIndicatorsLabel implements IDisposable {
// just to click into the one override there is.
this.scopeOverridesIndicator.element.style.display = 'inline';
this.scopeOverridesIndicator.element.classList.remove('setting-indicator');
this.scopeOverridesIndicator.disposables.clear();

const prefaceText = element.isConfigured ?
localize('alsoConfiguredIn', "Also modified in") :
Expand Down
Loading