support ~ completions, wrap file/folder completion item in quotes if it contains spaces
#234600
Conversation
| @@ -201,10 +201,14 @@ export class TerminalCompletionService extends Disposable implements ITerminalCo | |||
|
|
|||
| const parentDirPath = cwd.fsPath.split(resourceRequestConfig.pathSeparator).slice(0, -1).join(resourceRequestConfig.pathSeparator); | |||
| const parentCwd = URI.from({ scheme: cwd.scheme, path: parentDirPath }); | |||
| const homeDir = cwd.with({ path: '' }); | |||
There was a problem hiding this comment.
hm, just realized this isn't quite right. we need to get the $HOME var, but it's not available on process here
There was a problem hiding this comment.
I guess we have to wait until env is provided via shell integration?
There was a problem hiding this comment.
going to try terminal shell env service
There was a problem hiding this comment.
that causes a layering issue, which is a bummer bc it works so nicely 😢
There was a problem hiding this comment.
@meganrogge I think IShellEnvironmentService or similar* is what you want. To do this you'll need to create a base abstract TerminalCompletionService, then one for browser (that handles when HOME isn't available) and one for electron-sandbox (when HOME is available). Then pull via dependency injection and pass as args into super(). Look at ITerminalProfileResolverService for an example of how to do this.
* I notice it's in electron-sandbox though so you'll also need to pull the environment in the case of remotes. Maybe hold off on that since we'll be moving on to the upcoming shell environment API stuff which will have it on a new capability.
fixes #234352
also pulls more test variables into constants and makes two testSpec properties optional to reduce duplication