Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hover delay for Experimental setting #231970

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarquisMc
Copy link

@MarquisMc MarquisMc commented Oct 22, 2024

Fixes #231956

Reduce the hover delay for the 'Experimental' setting.

  • Add a new configuration setting workbench.experimental.hoverDelay with a default value of 150ms in src/vs/workbench/contrib/sash/browser/sash.contribution.ts.
  • Update the onDidChangeHoverDelay function in src/vs/workbench/contrib/sash/browser/sash.ts to consider the workbench.experimental.hoverDelay setting.
  • Add a new event listener for the workbench.experimental.hoverDelay setting in src/vs/workbench/contrib/sash/browser/sash.ts.

For more details, open the Copilot Workspace session.

Fixes microsoft#231956

Reduce the hover delay for the 'Experimental' setting.

* Add a new configuration setting `workbench.experimental.hoverDelay` with a default value of 150ms in `src/vs/workbench/contrib/sash/browser/sash.contribution.ts`.
* Update the `onDidChangeHoverDelay` function in `src/vs/workbench/contrib/sash/browser/sash.ts` to consider the `workbench.experimental.hoverDelay` setting.
* Add a new event listener for the `workbench.experimental.hoverDelay` setting in `src/vs/workbench/contrib/sash/browser/sash.ts`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/vscode/issues/231956?shareId=XXXX-XXXX-XXXX-XXXX).
@MarquisMc
Copy link
Author

@microsoft-github-policy-service agree

Copy link
Contributor

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe this PR fixes the issue. The bug, if there is one, is likely in src\vs\workbench\contrib\preferences\browser\settingsEditorSettingIndicators.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Experimental" setting hover takes a surprisingly long time to show up
2 participants