Unbreak ESLint #219628
Closed
Unbreak ESLint #219628
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great catch. |
dbaeumer
approved these changes
Jul 3, 2024
sandy081
approved these changes
Jul 3, 2024
|
@arvid220u your change doesn't pass the build pipeline since you formatted the code with spaces instead of tabs. I will redo the change. |
|
See #220037 for the merged pull request. To get this in all reported errors needed to fixed as well. |
auto-merge was automatically disabled
July 5, 2024 10:35
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 13a88a8, I believe that
yarn eslinthas been broken. It runs for 10 seconds and reports a success.The problem, I believe, is that
gulp-eslintdoes not parse double exclamation marks. This PR changes the double exclamation mark into no exclamation mark at all, which makeseslintwork again, and which I believe also makes the original intent of the 13a88a8 commit work.There seems to be a few lints that have gone unnoticed because of this, but I will leave that to subsequent PRs by the respective code owners.
I might be missing something! But figured I'd send it here in case I'm not :)