cli: use openssl for all crypto-related activities #163676
Merged
+572
−697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compliance with SDL and MSFT crypto standards. Right now this uses our forks of russh and secret-service. russh seems amenable to getting this merged (Eugeny/russh#52) but TBD about the secret-service crate. Fixes microsoft/vscode-internalbacklog#3158
rzhao271
approved these changes
Oct 14, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compliance with SDL and MSFT crypto standards. Right now this uses our forks of russh and secret-service. russh seems amenable to getting this merged (Eugeny/russh#52) but TBD about the secret-service crate.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/3158