Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @starting-style #421

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

lilnasy
Copy link

@lilnasy lilnasy commented Jan 1, 2025

  • Closes Support @starting-style #403
  • I implemented this by following the lead of support @container, prepare 6.2.10 #365 and support nested @container #390. If there is more to it, then lmk.
  • I noticed that ._parseContainerDeclaration(), ._parseMediaDeclaration(), ._parseSupportsDeclaration(), and ._parseLayerDeclaration() all contain the exact same logic. It seems community contributions over the years kept copying it.
  • To keep the review simple and the diff small, I didn't break the pattern and created a 5th copy in ._parseStartingStyleDeclaration(). Might be something to revisit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support @starting-style
1 participant