[libressl] Update to v4.0.0 #42145
Open
[libressl] Update to v4.0.0 #42145
+21
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First time updating a port so happy to do whatever is needed to land this. |
donny-dont
commented
Nov 14, 2024
ports/libressl/patches/0002-Add-option-to-enable-spectre-mitigation-in-MSVC.patch
Outdated
Show resolved
Hide resolved
ports/libressl/patches/0003-Disable-additional-MSVC-warnings.patch
Outdated
Show resolved
Hide resolved
LilyWangLL
added
the
category:port-update
dg0yt
reviewed
Nov 14, 2024
ports/libressl/patches/0002-Add-option-to-enable-spectre-mitigation-in-MSVC.patch
Outdated
Show resolved
Hide resolved
ports/libressl/patches/0003-Disable-additional-MSVC-warnings.patch
Outdated
Show resolved
Hide resolved
donny-dont
commented
Nov 14, 2024
ports/libressl/patches/0003-Disable-additional-MSVC-warnings.patch
Outdated
Show resolved
Hide resolved
ports/libressl/patches/0002-Add-option-to-enable-spectre-mitigation-in-MSVC.patch
Outdated
Show resolved
Hide resolved
Removes `0002-suppress-msvc-warnings.patch`. The warnings were fixed and upstreamed into a downloaded patch. The spectre mitigation flags should be added in a triplet file.
donny-dont
force-pushed
the
libressl-v4.0.0
branch
from
d96373e
to
5337eb9
Compare
donny-dont
force-pushed
the
libressl-v4.0.0
branch
from
5337eb9
to
7415604
Compare
|
Okay @dg0yt and @LilyWangLL think this is ready to go |
dg0yt
reviewed
Nov 15, 2024
Comment on lines
-1
to
-15
| diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
| index 2f0dfa0..594c56f 100644 | ||
| --- a/CMakeLists.txt | ||
| +++ b/CMakeLists.txt | ||
| @@ -136,6 +136,10 @@ if(WIN32) | ||
| endif() | ||
| set(PLATFORM_LIBS ${PLATFORM_LIBS} ws2_32 ntdll bcrypt) | ||
| endif() | ||
| +if(MSVC AND MSVC_VERSION GREATER_EQUAL 1912) | ||
| + message(STATUS "Setting /Qspectre switch") | ||
| + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /Qspectre") | ||
| +endif() | ||
|
|
||
| if(MSVC) | ||
| add_definitions(-Dinline=__inline) |
There was a problem hiding this comment.
I do note that the port would no longer unconditionally enable spectre mitigation for newer MSVC. (This implements what I said about the new feature. I highlight the change because it was hidden in a patch with a different topic.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.