Android CI with JDK and SDK #42080

dg0yt · 2024-11-09T21:46:20Z

Reprise from #35845.

dg0yt · 2024-11-10T07:41:38Z

@m-kuhn Elapsed time to handle qtbase:x64-android: 4.2 min

dg0yt · 2024-11-10T08:27:13Z

allegro5: Uses (downloads) gradle 5 which "supports running Gradle builds with JDK 11". Fails with:

Welcome to Gradle 5.0!

Here are the highlights of this release:
 - Kotlin DSL 1.0
 - Task timeouts
 - Dependency alignment aka BOM support
 - Interactive `gradle init`

For more details see https://docs.gradle.org/5.0/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)
java.lang.NoClassDefFoundError: Could not initialize class org.codehaus.groovy.vmplugin.v7.Java7

Java 17 support comes with gradle 7.3.

dg0yt · 2024-11-10T12:57:22Z

qtbase 6.7 silently overrides toolchain API level 21 with actual API level 23.
Some downstream errors are related to API level 21 again, e.g. kdsoap.

qtbase also selects ANDROID_STL=c++_shared despite VCPKG_CRT_LINKAGE=static.
Eventually leading to confusion downstream, and probably also with dependencies.

sandye51 · 2024-11-11T04:19:49Z

ports/allegro5/portfile.cmake

@@ -10,8 +10,8 @@ vcpkg_from_github(
        minimp3-fix.patch
 )

-if(VCPKG_TARGET_IS_ANDROID AND NOT ENV{ANDROID_HOME})
-    message(FATAL_ERROR "${PORT} requires environment variable ANDROID_HOME to be set." )
+if(VCPKG_TARGET_IS_ANDROID AND "$ENV{ANDROID_HOME}" STREQUAL "")


what is the difference?

The first one does't work, the second does. (I was surprised, too.)

dg0yt · 2024-11-11T06:01:35Z

ports/qtbase/cmake/qt_install_submodule.cmake

+    if(VCPKG_TARGET_IS_ANDROID)
+        # Qt requires libc++_shared, cf. <qtbase>/cmake/QtPlatformAndroid.cmake
+        # and https://developer.android.com/ndk/guides/cpp-support#sr
+        vcpkg_check_linkage(ONLY_DYNAMIC_CRT)
+    endif()


Modeling what is hard-coded in Qt.
Excludes it from vcpkg CI with its current Android configuration.

dg0yt · 2024-11-11T06:21:10Z

triplets/arm64-android.cmake

-set(VCPKG_CRT_LINKAGE static)
+set(VCPKG_CRT_LINKAGE dynamic)
 set(VCPKG_LIBRARY_LINKAGE static)
 set(VCPKG_CMAKE_SYSTEM_NAME Android)
 set(VCPKG_MAKE_BUILD_TRIPLET "--host=aarch64-linux-android")
 set(VCPKG_CMAKE_CONFIGURE_OPTIONS -DANDROID_ABI=arm64-v8a)
+set(VCPKG_CMAKE_SYSTEM_VERSION 28)


Probably not acceptable as part of this PR, but I strongly suggest these changes.

Runtime:

Static CRT linkage chooses static C++ runtime, but this is recommend only if "all of your application's native code is contained in a single shared library". IMO this limits the applicability of the android triplets and CI too much.

Qt only supports c++_shared, and the user's Qt app is a shared object dlopened by native Qt code.

linux and osx triplets also use dynamic CRT linkage.

API level:

At the moment vcpkg initializes API level to 21. This excludes many ports from vcpkg CI. "Cumulative usage": 99.6%

Qt 6.7 needs 23. "Cumulative usage": 98.6%

Many POSIX APIs come with 24. "Cumulative usage": 97.2%

Qt 6.8 (LTS) needs 28. "Cumulative usage": 91.7%

I don't know if the default shall be changed in the triplet or in android.cmake. (In manifest mode with CMake, this should be passed through IMO.)

CC @BillyONeal for team feedback.

More on Qt and API levels: https://www.qt.io/blog/qt-for-android-supported-versions-guidelines

For an API level adjustment which is acceptable for this PR: the qtbase port could show a warning (or error) if there are incompatible API levels and suggest setting it in the triplet, similar to what's discussed here https://github.com/microsoft/vcpkg/pull/41435/files#diff-da814fe5d578d93392e698157af490aeb2f7994eecdf94b272356ae97661ddc4R15-R17

vcpkg/ports/qtbase/cmake/qt_install_submodule.cmake

Lines 15 to 17 in c2e8695

if(VCPKG_TARGET_IS_OSX AND (NOT VCPKG_OSX_DEPLOYMENT_TARGET OR VCPKG_OSX_DEPLOYMENT_TARGET VERSION_GREATER_EQUAL "15.0"))

message(WARNING "Qt6.7 does not yet support macOS 15.0, consider adding set(VCPKG_OSX_DEPLOYMENT_TARGET 14.0) or earlier to a custom triplet (https://learn.microsoft.com/en-us/vcpkg/users/examples/overlay-triplets-linux-dynamic#overriding-default-triplets).")

endif()

A global vcpkg default system version policy similar or equal to the qt guideline could be discussed by the team in parallel

Well, we can show an error for an insufficient API level from the portfile, or add an config-time failure to qtbase.

The osx case is a little bit different: The osx doesn't sufficiently control the deployment target, but silently takes the host osx version. Probably breaking vcpkg's ABI tracking promises.

For now I'm still assessing how much CI can be done for Qt on Android, and I tried to trigger the discussion about where to move the android CI to.

Next barrier: Pristine Qt doesn't support static library linkage for Android.
Linking apps fails with error: duplicate symbol: JNI_OnLoad (Core lib, platform plugin).

https://bugreports.qt.io/browse/QTBUG-32618
https://bugreports.qt.io/browse/QTBUG-99108

Note that the older issue also links to another issue with androiddeployqt.

Looks like there is a patch for qtbase that has received positive feedback from the qtandroid team but didn't end up being merged (without visible reasons)
https://codereview.qt-project.org/c/qt/qtbase/+/279386

dg0yt and others added 6 commits November 9, 2024 09:15

Limit CI to android

2a0d82a

Acquire JDK and Android SDK

3ffdaaf

Cherry-picked from microsoft#35845

[qtbase] Use ANDROID_HOME

65d95b4

Fixup SDK root setup

894a200

Update qtbase for android

bde2088

Enable allegro5 CI on android

e3907fc

dg0yt marked this pull request as draft November 9, 2024 21:46

Fixup

f8fb09e

m-kuhn mentioned this pull request Nov 10, 2024

[qtbase] enable ci for android #35845

Closed

dg0yt force-pushed the qtbase-android branch 3 times, most recently from 7ba693a to c1181b6 Compare November 10, 2024 11:26

Fixup [skip actions]

4a69582

dg0yt force-pushed the qtbase-android branch from c1181b6 to 4a69582 Compare November 10, 2024 12:04

Add JDK and SDK installation to Dockerfile

ab7f09a

WangWeiLin-MV assigned JonLiu1993 Nov 11, 2024

JonLiu1993 added the category:infrastructure Pertaining to the CI/Testing infrastrucutre label Nov 11, 2024

sandye51 reviewed Nov 11, 2024

View reviewed changes

dg0yt added 3 commits November 11, 2024 06:28

Fixup

74b4392

SDK setup

99dc605

arm64-android: dynamic CRT, API level 28 [skip actions]

e9e8d5a

dg0yt commented Nov 11, 2024

View reviewed changes

dg0yt added 5 commits November 11, 2024 18:05

Merge remote-tracking branch 'origin/master' into qtbase-android

b56c1e6

Fixup [skip actions]

9476a57

Limit CI to arm64-android

1169884

[libiconv] Skip build for android >= 28

52af905

[qtsensors] Adapt to NDK >= 27

65136d0

dg0yt added 5 commits November 13, 2024 06:58

[freexl] Use builtin iconv on android >= 28

334f4c8

[calceph] Fix android

3de1b64

[allegro5] Fix android

777a415

[status-code] Fix android

70fb6dc

[skip actions]

7a21311

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android CI with JDK and SDK #42080

Android CI with JDK and SDK #42080

dg0yt commented Nov 9, 2024

dg0yt commented Nov 10, 2024

dg0yt commented Nov 10, 2024 •

edited

Loading

dg0yt commented Nov 10, 2024

sandye51 Nov 11, 2024

dg0yt Nov 11, 2024 •

edited

Loading

dg0yt Nov 11, 2024

dg0yt Nov 11, 2024 •

edited

Loading

dg0yt Nov 11, 2024

m-kuhn Nov 11, 2024 •

edited

Loading

dg0yt Nov 11, 2024

dg0yt Nov 12, 2024

m-kuhn Nov 12, 2024

	if(VCPKG_TARGET_IS_OSX AND (NOT VCPKG_OSX_DEPLOYMENT_TARGET OR VCPKG_OSX_DEPLOYMENT_TARGET VERSION_GREATER_EQUAL "15.0"))
	message(WARNING "Qt6.7 does not yet support macOS 15.0, consider adding set(VCPKG_OSX_DEPLOYMENT_TARGET 14.0) or earlier to a custom triplet (https://learn.microsoft.com/en-us/vcpkg/users/examples/overlay-triplets-linux-dynamic#overriding-default-triplets).")
	endif()

Android CI with JDK and SDK #42080

Are you sure you want to change the base?

Android CI with JDK and SDK #42080

Conversation

dg0yt commented Nov 9, 2024

dg0yt commented Nov 10, 2024

dg0yt commented Nov 10, 2024 • edited Loading

dg0yt commented Nov 10, 2024

sandye51 Nov 11, 2024

Choose a reason for hiding this comment

dg0yt Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

dg0yt Nov 11, 2024

Choose a reason for hiding this comment

dg0yt Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

dg0yt Nov 11, 2024

Choose a reason for hiding this comment

m-kuhn Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

dg0yt Nov 11, 2024

Choose a reason for hiding this comment

dg0yt Nov 12, 2024

Choose a reason for hiding this comment

m-kuhn Nov 12, 2024

Choose a reason for hiding this comment

dg0yt commented Nov 10, 2024 •

edited

Loading

dg0yt Nov 11, 2024 •

edited

Loading

dg0yt Nov 11, 2024 •

edited

Loading

m-kuhn Nov 11, 2024 •

edited

Loading