Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Set CMP0174 NEW #42045

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[vcpkg] Set CMP0174 NEW #42045

wants to merge 2 commits into from

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Nov 8, 2024

Fixes #41999.

This PR intentionally forces the new behavior:

  • The relevant spot in vcpkg scripts actually expect the new behavior.
  • Old behaviors are deprecated. vcpkg will eventually adopt the new behavior.
  • No change for users with CMake < 3.31.
    Ports outside vcpkg CI do not need updates unless they really rely on the deprecated behavior AND are used with CMake >=3.31.

Tested locally (with some ports). CI still uses at 3.30.

@dg0yt dg0yt changed the title Fix CMP0174 warning Set CMP0174 NEW Nov 8, 2024
@FrankXie05 FrankXie05 changed the title Set CMP0174 NEW [vcpkg] Set CMP0174 NEW Nov 8, 2024
@FrankXie05 FrankXie05 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Nov 8, 2024
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Nov 12, 2024
@xiaozhuai
Copy link
Contributor

xiaozhuai commented Nov 12, 2024

CMake Deprecation Warning at /opt/vcpkg/scripts/buildsystems/vcpkg.cmake:40 (cmake_policy):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
Call Stack (most recent call first):
  build/binary/arm64-ios-debug/CMakeFiles/3.31.0/CMakeSystem.cmake:6 (include)
  CMakeLists.txt:2 (project)

Please also fix this warning in user project that use cmake >= 3.31
Fixed by #41574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vcpkg scripts] CMake policy CMP0174 warning from every package with CMake 3.31
3 participants