Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openvdb] update to 12.0.0 and fix link error #42020

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[openvdb] update to 12.0.0 and fix link error #42020

wants to merge 10 commits into from

Conversation

JonLiu1993
Copy link
Member

@JonLiu1993 JonLiu1993 commented Nov 7, 2024 •
edited
Loading

Fixes #41951
Update openvdb to version 12.0.0
Fix link error and config error
Feature nanovdb and tools tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static

Usage tested successfully by openvdb:x64-windows

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Nov 7, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Nov 8, 2024

The patches still do not treat separate topics. Maybe it is easier if all three patches are combined.

dg0yt
dg0yt reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we see the whole picture, we can finally talk how to trim the patch to what is really needed.

Getting started...

ports/openvdb/fix_cmake.patch Outdated Show resolved Hide resolved
ports/openvdb/fix_cmake.patch Outdated Show resolved Hide resolved
@JonLiu1993 JonLiu1993 marked this pull request as ready for review November 14, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

Assignees

@jimwang118 jimwang118

Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[openvdb] update to 12.0.0
3 participants
@JonLiu1993 @dg0yt @jimwang118