-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Simplify cmake invokation in bootsrap.sh #41997
base: master
Are you sure you want to change the base?
[vcpkg] Simplify cmake invokation in bootsrap.sh #41997
Conversation
There's a [string escaping madness in bootstrap.sh's cmake invokation around line 217, making the script difficult to maintain. I broke it before in PR microsoft#36828 which went into master undetected as it "worked over here" (tm) and isn't executed by the CI, but appearently it wouldn't work on arch linux' bash, resulting in PR microsoft#37047 . microsoft/vcpkg-tool#1380 introduces a CMake Preset that can take over the cmake CLI variable setup. This commit replaces the nested string composition by it's cmake-preset counterpart.
14c4b9d
to
780983b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't use CMake presets because the current supported client CMake version is CMake 3.16.3, but CMake presets were added in 3.19. (I would be happy to take this in a couple years when our minimum is 3.19 though)
I'll set this to draft then and reset it when ubuntu 20.04 goes EOL in half a year :3 |
Maybe we don't care since most of the time we ship binaries now? |
Isn't everything on that list, other then Ubuntu 20.04, 24.04, Debian 11 and Debian 12, End of Life?
So basically the only linux distribution which doesn't yet ship cmake-3.20 or newer is ubuntu-20.04, which will EoL in half a year. I'm supprised we don't "care" for Ubuntu 22.04 though, despite there even being github hosted actions runners for them. |
There's a [string escaping madness in bootstrap.sh's cmake invokation around line 217, making the script difficult to maintain.
I broke it before in PR #36828 which went into master undetected as it "worked over here" (tm) and isn't executed by the CI, but appearently it wouldn't work on arch linux' bash, resulting in PR #37047 .
microsoft/vcpkg-tool#1380 introduces a CMake Preset that can take over the cmake CLI variable setup.
This commit replaces the nested string composition by it's cmake-preset counterpart.
Fixes #41996.