Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashpad] Fix build errors under linux #39671

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

jimwang118
Copy link
Contributor

@jimwang118 jimwang118 commented Jul 3, 2024

Fix one of #32398 issue.

src/951b70517d-a4e19cb5ec.clean/third_party/mini_chromium/mini_chromium/base/atomicops_internals_portable.h:57:25: error: cannot initialize a parameter of type 'int' with an lvalue of type 'const memory_order'
   57 |   __atomic_thread_fence(std::memory_order_seq_cst);

Modify issue based on upstream bug fix.
Since there is no Clang++ compiler on the CI linux machine, the compilation fails, so I can't remove crashpad:x64-linux=fail from ci.baseline.txt.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

x64-windows
x64-linux

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 3, 2024
@RealChuan
Copy link
Contributor

RealChuan commented Jul 4, 2024

chromium/crashpad@da18935
chromium/mini_chromium@b870d45
This is an upstream update, it may be better to update crashpad and mini_chromium versions

@jimwang118
Copy link
Contributor Author

chromium/crashpad@da18935 chromium/mini_chromium@b870d45 This is an upstream update, it may be better to update crashpad and mini_chromium versions

Thanks for your suggestion, it has been modified.

ports/crashpad/portfile.cmake Outdated Show resolved Hide resolved
@jimwang118
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jimwang118
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants