Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gettext-libintl] Handle atypical Linux installations #39662

Merged
merged 5 commits into from
Jul 5, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jul 3, 2024

Fix libintl.h detection on atypical Linux systems such as NixOS. Resolves #39641.
Adjust messages to cover musl libc systems. Resolves #39617. (Based on #39659.)
Add triplet variable to force build on linux. Useful for musl libc systems.
Report detected header location. Useful to discover inconsistencies. (My linux cross builds still detect the host header. The error message is unaware of cross builds.)

Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port installation tests pass with the following triplets:

  • x64-linux

@WangWeiLin-MV WangWeiLin-MV added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels Jul 3, 2024
@JavierMatosD JavierMatosD merged commit b593af9 into microsoft:master Jul 5, 2024
17 checks passed
@dg0yt dg0yt deleted the libintl branch July 5, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
3 participants