Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mimalloc] update to 2.1.7 #39650

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

nickdademo
Copy link
Contributor

@nickdademo nickdademo commented Jul 2, 2024

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Nick D'Ademo added 2 commits July 2, 2024 18:11
@nickdademo nickdademo changed the title [mimalloc] update to 2.17 [mimalloc] update to 2.1.7 Jul 2, 2024
@Cheney-W Cheney-W self-assigned this Jul 2, 2024
@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Jul 2, 2024
@nickdademo
Copy link
Contributor Author

Not sure on the exact cause of the CI failures yet... If anyone has hints, please let me know :)

@dg0yt
Copy link
Contributor

dg0yt commented Jul 3, 2024

There is a test port, and you can install it locally with

vcpkg install --overlay-ports=scripts/test-ports vcpkg-ci-mimalloc

For x64-linux, the CI logs show:

undefined reference to `_mi_page_malloc_zero(mi_heap_s*, mi_page_s*, unsigned long, bool)'

The test port pulls source code from the mimalloc repo, so you must also update it now.

@dg0yt
Copy link
Contributor

dg0yt commented Jul 4, 2024

Still failing with

page.c:(.text+0x25fb): undefined reference to `_mi_page_malloc_zero(mi_heap_s*, mi_page_s*, unsigned long, bool)'

@nickdademo
Copy link
Contributor Author

Still failing with

page.c:(.text+0x25fb): undefined reference to `_mi_page_malloc_zero(mi_heap_s*, mi_page_s*, unsigned long, bool)'

Are you able to post a link to this log? I didn't manage to find it :) Thanks!

@dg0yt
Copy link
Contributor

dg0yt commented Jul 4, 2024

You get to Azure pipeline by following the details links, then go to the assets, then find the download in the three dots on the right side when you hover the failure logs line.
#31357

It is a new mimalloc function, and I wonder if it is related to its extern inline definition. The command line doesn't set a C standard.

@Cheney-W
Copy link
Contributor

Cheney-W commented Jul 5, 2024

Moving the PR to draft. Please set it to "ready for review" once the CI test passed.

@Cheney-W Cheney-W marked this pull request as draft July 5, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants