Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tdscpp] Add new port #39599

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

maharmstone
Copy link
Contributor

@maharmstone maharmstone commented Jun 29, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@maharmstone
Copy link
Contributor Author

maharmstone commented Jun 29, 2024

It looks like the test failures are because CI is running an old version of GCC - I think we need at least GCC 13 for <format>. Is there any way to express that in vcpkg.json?

@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 1, 2024

vcpkg_cmake_install()

vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/tdscpp TARGET_PATH share/tdscpp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI shows invalid path:

CMake Error at D:/installed/x64-windows/share/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake:7 (message):
  vcpkg_cmake_config_fixup was passed extra arguments:
  TARGET_PATH;share/tdscpp
Call Stack (most recent call first):
  ports/tdscpp/portfile.cmake:24 (vcpkg_cmake_config_fixup)
  scripts/ports.cmake:192 (include)

https://dev.azure.com/vcpkg/public/_build/results?buildId=104505&view=logs&j=878666d5-db33-5b27-9e7d-b0c7ee352005&t=dc897974-8f7e-5107-e5db-0a01be8e9d4f&l=8025

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/tdscpp TARGET_PATH share/tdscpp)
vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/tdscpp)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI shows invalid path:

Actually it is an invalid option.

Comment on lines 28 to 32
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include)

# Handle copyright
file(COPY ${SOURCE_PATH}/LICENCE DESTINATION ${CURRENT_PACKAGES_DIR}/share/tdscpp)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/tdscpp/LICENCE ${CURRENT_PACKAGES_DIR}/share/tdscpp/copyright)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include)
# Handle copyright
file(COPY ${SOURCE_PATH}/LICENCE DESTINATION ${CURRENT_PACKAGES_DIR}/share/tdscpp)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/tdscpp/LICENCE ${CURRENT_PACKAGES_DIR}/share/tdscpp/copyright)
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include")
# Handle copyright
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENCE")

@FrankXie05
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review".
That way, I can be aware that you've responded since you can't modify the tags.

@FrankXie05 FrankXie05 marked this pull request as draft July 1, 2024 06:51
@FrankXie05 FrankXie05 changed the title [tdscpp] new port [tdscpp] Add new port Jul 1, 2024
@maharmstone
Copy link
Contributor Author

Thanks both, new commit pushed.

@FrankXie05, do you know what compiler versions your CI pipeline uses? I can target those as a minimum for future versions, if that makes things easier.

@maharmstone maharmstone marked this pull request as ready for review July 1, 2024 22:03
@FrankXie05
Copy link
Contributor

@FrankXie05, do you know what compiler versions your CI pipeline uses? I can target those as a minimum for future versions, if that makes things easier.

You can get all the information about CI compiler from here. :)
https://github.com/microsoft/vcpkg-tool/tree/main/azure-pipelines/vcpkg-linux

@dg0yt
Copy link
Contributor

dg0yt commented Jul 3, 2024

@FrankXie05, do you know what compiler versions your CI pipeline uses? I can target those as a minimum for future versions, if that makes things easier.

You can get all the information about CI compiler from here. :) https://github.com/microsoft/vcpkg-tool/tree/main/azure-pipelines/vcpkg-linux

No, that's for compiling the tool. For port CI, stay in this repo:
https://github.com/microsoft/vcpkg/tree/master/scripts/azure-pipelines
For Linux, CI uses Ubuntu 22.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants