-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tdscpp] Add new port #39599
base: master
Are you sure you want to change the base?
[tdscpp] Add new port #39599
Conversation
It looks like the test failures are because CI is running an old version of GCC - I think we need at least GCC 13 for <format>. Is there any way to express that in vcpkg.json? |
ports/tdscpp/portfile.cmake
Outdated
|
||
vcpkg_cmake_install() | ||
|
||
vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/tdscpp TARGET_PATH share/tdscpp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI shows invalid path:
CMake Error at D:/installed/x64-windows/share/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake:7 (message):
vcpkg_cmake_config_fixup was passed extra arguments:
TARGET_PATH;share/tdscpp
Call Stack (most recent call first):
ports/tdscpp/portfile.cmake:24 (vcpkg_cmake_config_fixup)
scripts/ports.cmake:192 (include)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/tdscpp TARGET_PATH share/tdscpp) | |
vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/tdscpp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI shows invalid path:
Actually it is an invalid option.
ports/tdscpp/portfile.cmake
Outdated
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include) | ||
|
||
# Handle copyright | ||
file(COPY ${SOURCE_PATH}/LICENCE DESTINATION ${CURRENT_PACKAGES_DIR}/share/tdscpp) | ||
file(RENAME ${CURRENT_PACKAGES_DIR}/share/tdscpp/LICENCE ${CURRENT_PACKAGES_DIR}/share/tdscpp/copyright) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include) | |
# Handle copyright | |
file(COPY ${SOURCE_PATH}/LICENCE DESTINATION ${CURRENT_PACKAGES_DIR}/share/tdscpp) | |
file(RENAME ${CURRENT_PACKAGES_DIR}/share/tdscpp/LICENCE ${CURRENT_PACKAGES_DIR}/share/tdscpp/copyright) | |
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include") | |
# Handle copyright | |
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENCE") |
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". |
Thanks both, new commit pushed. @FrankXie05, do you know what compiler versions your CI pipeline uses? I can target those as a minimum for future versions, if that makes things easier. |
You can get all the information about CI compiler from here. :) |
No, that's for compiling the tool. For port CI, stay in this repo: |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.