Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libarchive] Add Linux static build patch #38108

Closed
wants to merge 1 commit into from
Closed

[libarchive] Add Linux static build patch #38108

wants to merge 1 commit into from

Conversation

chrismile
Copy link
Contributor

Fixes #37987.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Unchecked items above indicate no change.

@chrismile chrismile changed the title Added Linux static build patch. [libarchive] Add Linux static build patch Apr 10, 2024
dg0yt
dg0yt suggested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be rejected.

ports/libarchive/fix-linux-static-build.patch
Comment on lines +9 to +11
+IF(UNIX AND NOT APPLE)
+ LIST(APPEND ADDITIONAL_LIBS "dl")
+ENDIF(UNIX AND NOT APPLE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. This is not how to add dl and this is not when to add dl.

@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Apr 11, 2024
dg0yt
dg0yt suggested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please close this PR.
#38398 is the right direction.

@chrismile chrismile closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt requested changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libarchive] Build failure on x64-linux (static only)
3 participants
@chrismile @dg0yt @MonicaLiu0311