Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[many ports] Include functional to fix error C2039 and C2504 #30946

Merged
merged 30 commits into from
Apr 27, 2023

Conversation

LilyWangLL
Copy link
Contributor

@LilyWangLL LilyWangLL commented Apr 18, 2023

In an internal version of Visual Studio, many ports install failed with following error:

error C2039: 'binary_function': is not a member of 'std'
error C2504: 'binary_function': base class undefined
error C2143: syntax error: missing ',' before '<'

Or

error C2039: 'unary_function': is not a member of 'std'
error C2504: 'unary_function': base class undefined
error C2143: syntax error: missing ',' before '<'

The reason is new STL change, need include <functional> to fix them.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

I have submitted an issue on upstream:
kpu/kenlm#428
themoos/core-moos#71

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Apr 18, 2023
@Neumann-A
Copy link
Contributor

error C2039: 'binary_function': is not a member of 'std'
error C2039: 'unary_function': is not a member of 'std'

maybe patch the use of these functions out since they have been deprecated since c++11 and are removed in 17 (Maybe there is an update upstream which already does this?)

@LilyWangLL LilyWangLL marked this pull request as ready for review April 19, 2023 07:49
@Cheney-W Cheney-W marked this pull request as draft April 20, 2023 01:58
@LilyWangLL LilyWangLL marked this pull request as ready for review April 20, 2023 09:59
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Apr 21, 2023
@BillyONeal
Copy link
Member

maybe patch the use of these functions out since they have been deprecated since c++11 and are removed in 17 (Maybe there is an update upstream which already does this?)

I think that crosses into 'upstream needs to be in the loop' territory where just add standard library header can be considered 'fairly mindless'.

ports/libsbml/fix-cmake.patch Outdated Show resolved Hide resolved
@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Apr 21, 2023
@BillyONeal BillyONeal added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed requires:author-response labels Apr 26, 2023
@BillyONeal
Copy link
Member

Tagging vcpkg-team-review for the 'rename upstream targets' question.

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @dg0yt has pointed out a legitimate problem with the edits to libsbml. It might be a good idea to separate that into its own PR since it is very much not "include functional" like the other changes here.

Thanks!

@BillyONeal BillyONeal added requires:author-response and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Apr 27, 2023
@LilyWangLL
Copy link
Contributor Author

I think @dg0yt has pointed out a legitimate problem with the edits to libsbml. It might be a good idea to separate that into its own PR since it is very much not "include functional" like the other changes here.

Thanks!

Done. I reverted the changes of libsbml, I will submit a new PR to update libsbml.

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@BillyONeal BillyONeal merged commit 2b1d52a into microsoft:master Apr 27, 2023
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Apr 27, 2023
@LilyWangLL LilyWangLL deleted the dev/LilyWang/CI_Unstable_0417 branch May 6, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants