-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Improve documentation and implementation of Typekit, Mutator, and Realm #5149
[core] Improve documentation and implementation of Typekit, Mutator, and Realm #5149
Conversation
All changed packages have been documented.
Show changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to also do JSDocs, super helpful!
You can try these changes here
|
…-typekit-mutator-docs
realm
is a readonly property of the typekit.$
has been merged with a function that gets a typekit bound to a specific realm ($(realm)
) or bound to the default typekit realm of a specific program ($(program)
) making it easier to work in specific program contexts (e.g. ProjectedProgram). The default typekit bound to a realm is cached in the Realm itself.createTypekit
directly, bypassing the realm-caching behavior.MutableType
for accuracy. The previous definition was inaccurate and would fail to represent mutations of literal types correctly.