Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on augment expr #4926

Draft
wants to merge 85 commits into
base: main
Choose a base branch
from
Draft

Error on augment expr #4926

wants to merge 85 commits into from

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Oct 31, 2024 •
edited
Loading

pr off #4849 that adds a breaking change that validate that you cannot augment model expression instead of just silently failing

Needs to be rebased when #4849 is merged

bterlson and others added 30 commits November 6, 2023 18:07
@bterlson
Symbol refactor
976ebd2
@bterlson
Resolve templates and template parameters with constraints, handle in…
7c43cbc 
…terfaces
@bterlson
Finish name resolution
b6f57f5
@timotheeguerin
Merge branch 'main' of https://github.com/Microsoft/typespec into sym…
e6ac53b 
…bol-refactor-2
@timotheeguerin
Fix
0159e87
@timotheeguerin
fix
f349cbc
@timotheeguerin
Fix binder tests
50d8b82
@timotheeguerin
name resolver running all tests
a33d29a
@timotheeguerin
try this
024e86e
@timotheeguerin
Fix need prototypes intrinsic
de4ad75
@timotheeguerin
fix const declaration
7c37496
@timotheeguerin
missing scalar constructor binding
6adf46c
@timotheeguerin
Prep
d130011
@timotheeguerin
fix js namespace resolution
2d86335
@timotheeguerin
remove only
f7a724a
@timotheeguerin
Fix circular symbol references
8a171ea
@timotheeguerin
fixup
03360a2
@timotheeguerin
progress
9772506
@timotheeguerin
cleanup
9a44ab1
@timotheeguerin
Merge branch 'main' of https://github.com/Microsoft/typespec into sym…
9e519a4 
…bol-refactor-2
@timotheeguerin
symbol flag printer
a867911
@timotheeguerin
progress with alias
0dc500b
@timotheeguerin
Fix null
c5d073f
@timotheeguerin
prog resovle ref fix
e3bc1ff
@timotheeguerin
Fix scalar constructor reoslution
f2c15e0
@timotheeguerin
progress
8f97a72
@timotheeguerin
fix usings
e537528
@timotheeguerin
fix augment
4a376c4
@timotheeguerin
fix references
a6ed238
@timotheeguerin
cleanup
6fc458e
timotheeguerin and others added 26 commits October 29, 2024 12:26
@timotheeguerin
Progress
5c260ca
@timotheeguerin
Fix cannot load picocolors in playground
ece8ad1
@timotheeguerin
Remove bindAndResolveNode export
a96ba54
@timotheeguerin
fix deprecation
59c9f57
@timotheeguerin
document
afc70a1
@timotheeguerin
move util
544094d
@timotheeguerin
can reenable tests
2398953
@timotheeguerin
Merge branch 'main' into symbol-refactor-2
6848511
@timotheeguerin
Create symbol-refactor-2-2024-9-29-20-20-29.md
cef5406
@timotheeguerin
Create symbol-refactor-2-2024-9-29-20-20-30.md
3648c1d
@timotheeguerin
Update symbol-refactor-2-2024-9-29-20-20-29.md
1ee1802
@timotheeguerin
Fix augment alias of model expression and symplify getAliasedSymbol
c270883
@timotheeguerin
More augment decorator tests
a6ee210
@timotheeguerin
More circular reference issue tests
ba65b66
@timotheeguerin
fix moved
90a19e3
@timotheeguerin
keep here for now
78fe93d
@timotheeguerin
Stop reporting ambigous error in name resolver and move to checker
1ac5155
@timotheeguerin
Better circular symbol reference detection
c2a192f
@timotheeguerin
Fix crash when trying to access member on non member container
19fcc1e
@timotheeguerin
Merge branch 'main' of https://github.com/Microsoft/typespec into sym…
d4bd341 
…bol-refactor-2
@timotheeguerin
Move duplicate symbol check to checker
8f8835f
@timotheeguerin
Improve usings
182ef87
@timotheeguerin
Fix regression in spec repo
2ed0bba
@timotheeguerin
Fix regression
95826f1
@timotheeguerin
rename
e695ffd
@timotheeguerin
Error when trying to augment expression
34961b4
@timotheeguerin timotheeguerin added the breaking-change A change that might cause specs or code to break label Oct 31, 2024
@azure-sdk
Copy link
Collaborator

All changed packages have been documented.

  • ✅ @typespec/compiler
  • ✅ @typespec/openapi3
Show changes

@typespec/compiler - feature ✏️

Overall of the symbol resolution. TypeSpec is able to resolve anything that can be statically linked. Augment decorators in turn are able to target any statically linkable types.

@typespec/openapi3 - internal ✏️

Fix test host

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@timotheeguerin timotheeguerin mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RodgeFu RodgeFu Awaiting requested review from RodgeFu RodgeFu will be requested when the pull request is marked ready for review RodgeFu is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson will be requested when the pull request is marked ready for review bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl will be requested when the pull request is marked ready for review markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang will be requested when the pull request is marked ready for review allenjzhang is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
breaking-change A change that might cause specs or code to break
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timotheeguerin @azure-sdk @bterlson