http-client-java, unknown default to Java Object #4868
Draft
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:java
|
No changes needing a change description found. |
|
You can try these changes here
|
weidongxu-microsoft
force-pushed
the
http-client-java_unknown-default-to-object
branch
from
2fbc0ea
to
882d590
Compare
weidongxu-microsoft
force-pushed
the
http-client-java_unknown-default-to-object
branch
from
882d590
to
d4faa6b
Compare
| @@ -30,7 +30,7 @@ public class EmitterOptions implements JsonSerializable<EmitterOptions> { | |||
| private String customizationClass; | |||
| private Boolean includeApiViewProperties = true; | |||
|
|
|||
| private Boolean useObjectForUnknown = false; | |||
| private Boolean useObjectForUnknown = true; | |||
There was a problem hiding this comment.
There should be a nominal use-object-for-unknown default to true in emitter.ts (it won't take effect). Though currently it was true there (a prior mistake).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE, unless there is a need to release a typespec-java with new changes in code, and we hadn't reached a decision of whether default to
BinaryDataorObject(or reached a decision to useObjectas default).If we merge this, the Generate.ps1 in autorest.java would need similar changes after bump core version and copy the test code.
https://github.com/microsoft/typespec/pull/4868/files#diff-5824bda07f6bda3ae83248b67a7418ac97b6da3a726ff5f17f8d6d976915031e