Allow trailing delimited in most locations #4837
Open
+28
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
bterlson,
markcowl and
allenjzhang
as code owners
microsoft-github-policy-service
bot
added
the
compiler:core
|
All changed packages have been documented.
Show changes
|
timotheeguerin
commented
Oct 23, 2024
| @@ -269,7 +267,6 @@ namespace ListKind { | |||
| delimiter: Token.Comma, | |||
| toleratedDelimiter: Token.Semicolon, | |||
| toleratedDelimiterIsValid: false, | |||
| trailingDelimiterIsValid: false, | |||
| invalidAnnotationTarget: "expression", | |||
There was a problem hiding this comment.
There is one case where it still doesn't work and its the heritage case.
interface A {};
interface B {};
interface O extends A, B, {} // Bad diagnostic, which is curious
that was already not showing the trailing-token error before either and this really also feels pointless to really support as the goal of trailing delimiter is usally to reduce diff when adding a new line on multi line and for interface interitance the last line is already trailed with {
|
You can try these changes here
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2284
fix #809
Extracted the parser change from pr #4372 and made it more generic to cover also issue #809