Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rapidhash #17422

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Upgrade to rapidhash #17422

wants to merge 7 commits into from

Conversation

Nicoshev
Copy link

@Nicoshev Nicoshev commented Jun 11, 2024

Upgrading 64-bit from wyhash to rapidhash.

The wyhash owner has recognized rapidhash as the official successor in its repo.

rapidhash has shown to be faster and of higher quality than wyhash.

It is also officially compatible with MSVC across all architectures.

References and Relevant Issues

rapidhash is currently the fastest recommended hash function by SMHasher.

rapidhash is currently the fastest passing hash in SMHasher3.

Collision-based study showing a collision probability lower than wyhash and close to ideal.

@Nicoshev
Copy link
Author

@microsoft-github-policy-service agree

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gating on @lhecker as the final signoff, as he's the one who chose and integrated wyahsh

src/inc/til/rapidhash.h Outdated Show resolved Hide resolved
src/inc/til/rapidhash.h Outdated Show resolved Hide resolved
src/inc/til/rapidhash.h Outdated Show resolved Hide resolved
src/inc/til/rapidhash.h Outdated Show resolved Hide resolved
src/inc/til/rapidhash.h Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants