Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile - upgrade nccl version and install ucx to fix bug in cuda 12.4 docker file #646

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

yukirora
Copy link
Contributor

Description
fix bug in cuda 12.4 docker file

Major Revision

  • upgrade nccl due to OOM bug in nccl v2.20 graph mode
  • install ucx 1.16 for mutli thread support for mpi in ib-traffic

@yukirora yukirora requested a review from a team as a code owner September 17, 2024 13:52
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.78%. Comparing base (f42835a) to head (607b893).
Report is 1 commits behind head on release/0.11.

Additional details and impacted files
@@              Coverage Diff              @@
##           release/0.11     #646   +/-   ##
=============================================
  Coverage         85.78%   85.78%           
=============================================
  Files                97       97           
  Lines              6923     6923           
=============================================
  Hits               5939     5939           
  Misses              984      984           
Flag Coverage Δ
cpu-python3.6-unit-test 71.61% <ø> (ø)
cpu-python3.7-unit-test 71.61% <ø> (ø)
cpu-python3.8-unit-test 71.64% <ø> (ø)
cuda-unit-test 83.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dockerfile/cuda12.4.dockerfile Outdated Show resolved Hide resolved
dockerfile/cuda12.4.dockerfile Outdated Show resolved Hide resolved
@yukirora yukirora enabled auto-merge (squash) September 20, 2024 06:21
@cp5555 cp5555 mentioned this pull request Sep 20, 2024
22 tasks
@yukirora yukirora merged commit 1d2d054 into release/0.11 Sep 20, 2024
17 of 22 checks passed
@yukirora yukirora deleted the yutji/upgrade-nccl branch September 20, 2024 09:37
yukirora added a commit that referenced this pull request Oct 8, 2024
…12.4 docker file (#646)

**Description**
fix bug in cuda 12.4 docker file


**Major Revision**
- upgrade nccl due to OOM bug in nccl v2.20 graph mode
- install ucx 1.16 for mutli thread support for mpi in ib-traffic
yukirora added a commit that referenced this pull request Oct 10, 2024
**Description**
Cherry pick bug fixes from v0.11.0 to main

**Major Revision**
* #645 
* #648 
* #646 
* #647 
* #651 
* #652 
* #650

---------

Co-authored-by: hongtaozhang <[email protected]>
Co-authored-by: Yifan Xiong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants