-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile - upgrade nccl version and install ucx to fix bug in cuda 12.4 docker file #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.11 #646 +/- ##
=============================================
Coverage 85.78% 85.78%
=============================================
Files 97 97
Lines 6923 6923
=============================================
Hits 5939 5939
Misses 984 984
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
abuccts
approved these changes
Sep 19, 2024
yzygitzh
approved these changes
Sep 19, 2024
yukirora
added a commit
that referenced
this pull request
Oct 8, 2024
…12.4 docker file (#646) **Description** fix bug in cuda 12.4 docker file **Major Revision** - upgrade nccl due to OOM bug in nccl v2.20 graph mode - install ucx 1.16 for mutli thread support for mpi in ib-traffic
yukirora
added a commit
that referenced
this pull request
Oct 10, 2024
**Description** Cherry pick bug fixes from v0.11.0 to main **Major Revision** * #645 * #648 * #646 * #647 * #651 * #652 * #650 --------- Co-authored-by: hongtaozhang <[email protected]> Co-authored-by: Yifan Xiong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix bug in cuda 12.4 docker file
Major Revision