Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update omegaconf version to 2.3.0 #631

Merged
merged 8 commits into from
Jul 23, 2024

Conversation

RyoYang
Copy link
Contributor

@RyoYang RyoYang commented Jul 11, 2024

Update omegaconf version to 2.3.0 as omegaconf 2.0.6 has a non-standard dependency specifier PyYAML>=5.1.*. pip 24.1 will enforce this behaviour change.
Discussion can be found at pypa/pip#12063

image

@RyoYang RyoYang requested a review from a team as a code owner July 11, 2024 12:15
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.78%. Comparing base (7435f10) to head (86138e2).

Files Patch % Lines
superbench/runner/runner.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   85.79%   85.78%   -0.02%     
==========================================
  Files          97       97              
  Lines        6915     6920       +5     
==========================================
+ Hits         5933     5936       +3     
- Misses        982      984       +2     
Flag Coverage Δ
cpu-python3.6-unit-test 71.59% <93.75%> (-0.01%) ⬇️
cpu-python3.7-unit-test 71.59% <93.75%> (-0.01%) ⬇️
cpu-python3.8-unit-test 71.62% <93.75%> (-0.40%) ⬇️
cuda-unit-test 83.86% <93.75%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

setup.py Show resolved Hide resolved
Copy link
Contributor

@cp5555 cp5555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange to set the upper version

@cp5555 cp5555 mentioned this pull request Jul 23, 2024
16 tasks
@yukirora
Copy link
Contributor

Is this change compatible with the old pip like 22.0.1?

@RyoYang
Copy link
Contributor Author

RyoYang commented Jul 23, 2024

Is this change compatible with the old pip like 22.0.1?
It should be compatible, cpu-unit-test pipeline (Job python3.6) passed all ut and it used a lower version of pip 21.2.4.

@abuccts abuccts merged commit 9a3ce39 into microsoft:main Jul 23, 2024
17 of 22 checks passed
@dong0321
Copy link

dong0321 commented Aug 9, 2024

image

Seems to be the same issue. I am building release/0.10 with rocm6.0 dockerfile.

@dong0321
Copy link

dong0321 commented Aug 9, 2024

@RyoYang could please check if this need to be fixed also in release/0.10

@dong0321
Copy link

dong0321 commented Aug 9, 2024

Build successed after change to 2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants