[heft-*-rig] Update the "moduleResolution" TSConfig compilerOption to "Node16" to add support for the "exports" pacakge.json field.
#4738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
octogonz
approved these changes
May 27, 2024
…"` to add support for the `"exports"` `pacakge.json` field.
iclanton
force-pushed
the
resolution-node16
branch
from
cff5aa8
to
5f6d3eb
Compare
| @@ -21,7 +21,8 @@ | |||
| "types": ["heft-jest"], | |||
| "typeRoots": ["../../../../../node_modules/@types", "../../node_modules/@types"], | |||
|
|
|||
| "module": "commonjs", | |||
| "module": "Node16", | |||
There was a problem hiding this comment.
I understand the change to moduleResolution, but why the change to module?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps the
"moduleResolution"TSConfigcompilerOptionto the more modern"Node16"to add support for the"exports"pacakge.jsonfield.How it was tested
Built.