[rush] Support "disableBuildCache" option in phased command schema #4306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
iclanton,
octogonz,
apostolisms and
D4N14L
as code owners
|
Might need to delve into ProjectChangeAnalyzer a bit more. |
octogonz
reviewed
Sep 1, 2023
common/changes/@microsoft/rush/run-before-install_2023-09-01-20-06.json
Outdated
Show resolved
Hide resolved
octogonz
reviewed
Sep 1, 2023
dmichon-msft
force-pushed
the
run-before-install
branch
from
f67b2de
to
445eac5
Compare
dmichon-msft
changed the title
iclanton
reviewed
Sep 3, 2023
Co-authored-by: Ian Clanton-Thuon <[email protected]>
iclanton
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
disableBuildCacheoption to the schema for phased commands (it is already present for bulk commands). Setting this flag opts out of both the build cache and the legacy skip logic.Details
Also adds an internal property
_runsBeforeInstallonPhasedScriptAction. Intended use case is for, e.g., #4229How it was tested
Temporarily set up a custom command with the flag enabled and disabled and stepped through in the debugger to validate the code paths.
Impacted documentation
Docs for
command-line.jsonfor phased commands.@chengcyber