Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing predefined recognizers to use the config file #1393

Merged
merged 22 commits into from
Jul 17, 2024

Conversation

RoeyBC
Copy link
Collaborator

@RoeyBC RoeyBC commented May 30, 2024

Change Description

This PR is going to accomplish the following:

  1. Refactor load_predefined_recognizers to load the settings from the default yml file
  2. Add warning in case recognizer is listed with a language not supported by the registry
  3. raise an exception in case there's discrepancy between the supported language in the registry and the one listed in the analyzer
  4. Edit the docs accordingly I guess :D

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@RoeyBC
Copy link
Collaborator Author

RoeyBC commented May 31, 2024

image
when refactored the codebase, added documentation & testing and you've got less text, you know it's a good change :D

SharonHart
SharonHart previously approved these changes Jul 14, 2024
@viclang
Copy link

viclang commented Jul 17, 2024

Currently I can't import from presidio_analyzer import RecognizerRegistryProvider, AnalyzerEngineProvider in presidio-analyzer 2.2.354. Will this release also solve that problem?

@omri374 omri374 merged commit c059131 into main Jul 17, 2024
32 checks passed
@omri374 omri374 deleted the feature/load_recognizer_logic_refactor branch July 17, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants