Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(roll): roll Firefox to r1467 #34168

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Dec 30, 2024

Unknown reason why there is no auto-roll PR for it. macOS tests are failing and its producing something like this instead:

telegram-cloud-photo-size-2-5449420304796476469-y

@mxschmitt mxschmitt added the CQ1 label Dec 30, 2024
Copy link
Contributor

Test results for "tests 1"

9 flaky ⚠️ [chromium-page] › page/page-event-request.spec.ts:110:3 › should report navigation requests and responses handled by service worker @chromium-ubuntu-22.04-node20
⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-setup.spec.ts:98:5 › should show errors in config @macos-latest-node18-1
⚠️ [installation tests] › playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-macos-latest
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:149:1 › should open simple trace viewer @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1537:1 › canvas clipping in iframe @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18

37460 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests others"

21428 passed, 509 skipped
✔️✔️✔️

Merge workflow run.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

Test results for "tests 2"

1 fatal errors, not part of any test
13 failed
❌ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-beta-macos-latest
❌ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options @firefox-headed-macos-14-xlarge
❌ [firefox-library] › library/video.spec.ts:189:5 › screencast › should capture static page @firefox-headed-macos-14-xlarge
❌ [firefox-library] › library/video.spec.ts:209:5 › screencast › should continue recording main page after popup closes @firefox-headed-macos-14-xlarge
❌ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge
❌ [firefox-library] › library/video.spec.ts:581:5 › screencast › should capture static page in persistent context @smoke @firefox-headed-macos-14-xlarge
❌ [firefox-library] › library/video.spec.ts:725:5 › screencast › should capture full viewport @firefox-headed-macos-14-xlarge
❌ [firefox-library] › library/video.spec.ts:760:5 › screencast › should capture full viewport on hidpi @firefox-headed-macos-14-xlarge
❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work @smoke @msedge-beta-ubuntu-20.04
❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work @smoke @msedge-dev-macos-latest
❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest
❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:42:3 › context.addCookies() should work @msedge-dev-ubuntu-20.04
❌ [webkit-library] › library/trace-viewer.spec.ts:1580:1 › should show a popover @webkit-macos-13-xlarge

115 flaky ⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @channel-chromium-macos-latest
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @channel-chromium-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @channel-chromium-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:581:5 › screencast › should capture static page in persistent context @smoke @channel-chromium-windows-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:436:5 › run-server › should respect selectors @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest
⚠️ [chromium-library] › library/har.spec.ts:82:3 › should have pages in persistent context @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @chrome-beta-macos-latest
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log @smoke @chrome-beta-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy @smoke @chrome-beta-macos-latest
⚠️ [chromium-library] › library/signals.spec.ts:25:5 › should close the browser when the node process closes @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @chrome-beta-windows-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @chrome-beta-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-beta-windows-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:424:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-python.spec.ts:78:5 › should save the codegen output to a file if specified @chrome-macos-latest
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log @smoke @chrome-macos-latest
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level @chrome-macos-latest
⚠️ [chromium-library] › library/signals.spec.ts:78:7 › signals › should close the browser on SIGINT @chrome-macos-latest
⚠️ [chromium-library] › library/tracing.spec.ts:370:5 › should survive browser.close with auto-created traces dir @chrome-macos-latest
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1221:1 › should pick locator in iframe @chromium-macos-13-large
⚠️ [chromium-library] › library/video.spec.ts:442:5 › screencast › should work for popups @chromium-macos-13-xlarge
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:930:7 › cli codegen › should clear when recording is disabled @chromium-tip-of-tree-ubuntu-20.04--headed
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1091:1 › should pick locator @chromium-tip-of-tree-windows-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @chromium-tip-of-tree-windows-latest--headed
⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-20.04
⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/trace-viewer.spec.ts:911:1 › should show action source @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:230:5 › should work when owner frame detaches @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/browsercontext-proxy.spec.ts:203:3 › should work with IP:PORT notion @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:428:7 › cli codegen › should check input with chaining id @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest
⚠️ [firefox-library] › library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest
⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1221:1 › should pick locator in iframe @firefox-macos-13-large
⚠️ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-macos-13-large
⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large
⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large
⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-20.04
⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04
⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:198:5 › launchServer › should be able to connect two browsers at the same time @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-beta-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @msedge-beta-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:581:5 › screencast › should capture static page in persistent context @smoke @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:42:3 › context.addCookies() should work @msedge-beta-ubuntu-20.04
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:64:3 › context.clearCookies() should work @msedge-beta-windows-latest
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:141:5 › launchServer › should be able to reconnect to a browser @msedge-dev-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work @smoke @msedge-dev-ubuntu-20.04
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:269:1 › should continue issuing events after closing the reused page @msedge-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-macos-latest
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-macos-latest
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04
⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @tracing-webkit
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:462:7 › cli codegen › should record ArrowDown @webkit-headed-ubuntu-20.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:509:7 › cli codegen › should check @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-ubuntu-22.04
⚠️ [webkit-page] › page/elementhandle-misc.spec.ts:27:3 › should hover when Node is removed @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:867:7 › cli codegen › should click button with nested div @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:585:7 › cli codegen › should consume pointer events @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-windows-latest
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1524:1 › canvas clipping @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge
⚠️ [webkit-page] › page/page-request-continue.spec.ts:185:5 › post data › should amend post data @webkit-macos-14-xlarge
⚠️ [webkit-page] › page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data @webkit-macos-15-large
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1524:1 › canvas clipping @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge
⚠️ [webkit-page] › page/page-request-continue.spec.ts:215:5 › post data › should amend method and post data @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-20.04
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-ubuntu-20.04
⚠️ [webkit-library] › library/screenshot.spec.ts:66:14 › page screenshot › should work with a mobile viewport and fullPage @webkit-ubuntu-20.04
⚠️ [webkit-library] › library/screenshot.spec.ts:96:14 › page screenshot › should work with device scale factor and scale:css @webkit-ubuntu-20.04
⚠️ [webkit-library] › library/screenshot.spec.ts:219:14 › element screenshot › element screenshot should work with device scale factor @webkit-ubuntu-20.04

253047 passed, 9784 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt marked this pull request as draft January 2, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant