Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(reporter): add another surrogate pair test case #33428

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Nov 4, 2024

Pavel asked for more surrogate pair test cases. I noticed we already had some, but I've added another test case that's special, in that not even VS Code handles it correctly. If you hit backspace on the character, it gets split up into its components:

Screen.Recording.2024-11-04.at.16.18.07.mov

The VS Code bug is tracked in microsoft/vscode#99629 and it's purportedly closed completed - not sure if i'm seeing a regression. At least Playwright knows how to handle it :D

@pavelfeldman let me know in case you meant a different kind of character and I remembered wrong.

@Skn0tt Skn0tt self-assigned this Nov 4, 2024
@Skn0tt
Copy link
Member Author

Skn0tt commented Nov 4, 2024

I've also taken a look at inlining get-east-asian-width. It consists of a couple hundred lines of lookup table. Otherwise, the package is as lean as can be. I don't think we can save much space or maintenance by vendoring this into our repository, so let's leave it as is.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Test results for "tests 1"

3 flaky ⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:52:5 › should print the correct context options when using a device @chromium-ubuntu-22.04-node20
⚠️ [installation tests] › playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest
⚠️ [webkit-library] › library/browsercontext-add-cookies.spec.ts:429:3 › should allow unnamed cookies @webkit-ubuntu-22.04-node18

36741 passed, 678 skipped
✔️✔️✔️

Merge workflow run.

@Skn0tt Skn0tt merged commit 26a7dd4 into microsoft:main Nov 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants