chore(ui): handle trace not being available without exceptions #33427
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"1 failed 36743 passed, 678 skipped Merge workflow run. |
pavelfeldman
reviewed
Nov 4, 2024
| @@ -54,6 +54,8 @@ async function loadTrace(traceUrl: string, traceFileName: string | null, clientI | |||
| const backend = traceUrl.endsWith('json') ? new FetchTraceModelBackend(traceUrl) : new ZipTraceModelBackend(traceUrl, fetchProgress); | |||
| await traceModel.load(backend, unzipProgress); | |||
| } catch (error: any) { | |||
| if (error?.message === 'trace not found') | |||
There was a problem hiding this comment.
Looks like you are mostly addressing the malformed (empty) JSON in live mode. Should we check that at parse time and return empty trac instead?
There was a problem hiding this comment.
That's a nice idea as well, but I think it'd be more complex. Just one example, we're treating empty traces as an error while parsing:
playwright/packages/trace-viewer/src/sw/traceModel.ts
Lines 52 to 53 in 26a7dd4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The control flow for loading live traces is currently based on exceptions, and it's hard to follow. It's expected that the live trace only becomes available after a couple retries, but the code doesn't reflect that.
This PR adds some handling for 404s so we represent the "trace not yet available" state with 404 responses instead of
errors. It also renames the
counterstate torerenderto make the intent clearer.Console before this change:
Console after this change:
Closes #33339.