Fix/dotnet code snippets for text and goto #33382
Conversation
Test results for "tests 1"28 failed 35361 passed, 625 skipped Merge workflow run. |
|
I think the snippets are correct as they are. Could you outline what's the problem in your opinion? |
|
For dotnet, it should be Page and not page and this is visible in almost
all the dotnet snippets in the doc.
…On Thu, Oct 31, 2024 at 4:18 PM Simon Knott ***@***.***> wrote:
I think the snippets are correct as they are. Could you outline what's the
problem in your opinion?
—
Reply to this email directly, view it on GitHub
<#33382 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMJJJTCM52A2H35UHY44B4DZ6JC4XAVCNFSM6AAAAABQ6M7A6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJQGE2DONBYGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Also, my plan is to have a look at the snippets used for dotnet and update
as much as possible.
On Thu, Oct 31, 2024 at 4:25 PM onyedikachi hope ***@***.***>
wrote:
… For dotnet, it should be Page and not page and this is visible in almost
all the dotnet snippets in the doc.
On Thu, Oct 31, 2024 at 4:18 PM Simon Knott ***@***.***>
wrote:
> I think the snippets are correct as they are. Could you outline what's
> the problem in your opinion?
>
> —
> Reply to this email directly, view it on GitHub
> <#33382 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AMJJJTCM52A2H35UHY44B4DZ6JC4XAVCNFSM6AAAAABQ6M7A6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJQGE2DONBYGU>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/identifier-names#naming-conventions says that local variables should be in |
|
Yes, for local variables that's why some of the snippets were not updated
because a variable creation was clearly stated in the snippets. For example;
https://playwright.dev/dotnet/docs/auth
https://playwright.dev/dotnet/docs/network
However, have a look at the different pattern for nodesjs, python, java,
dotnet in this snippet, also the snippets for dotnet here is wrong and the fix is part of this pr.
https://playwright.dev/docs/api/class-page#page-get-by-text
Lastly, have a look at the snippets in dialogs that works perfectly;
https://playwright.dev/dotnet/docs/dialogs
So for an absolute beginner that wants to get started, snippets are guides
and they are mostly used the way it is written in the docs- using e.g
page.GetByText for a dotnet app will fail.
…On Thu, Oct 31, 2024 at 4:30 PM Simon Knott ***@***.***> wrote:
https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/identifier-names#naming-conventions
says that local variables should be in camelCase, and the snippets this
PR updates are all assuming page to be a local variable. Am I missing
something?
—
Reply to this email directly, view it on GitHub
<#33382 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMJJJTB7G4LHPSHT36SNRFTZ6JEHTAVCNFSM6AAAAABQ6M7A6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJQGE3TIOJYGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Or isn’t this the expectation for the dotnet docs?
On Thu, Oct 31, 2024 at 4:46 PM onyedikachi hope ***@***.***>
wrote:
… Yes, for local variables that's why some of the snippets were not updated
because a variable creation was clearly stated in the snippets. For example;
https://playwright.dev/dotnet/docs/auth
https://playwright.dev/dotnet/docs/network
However, have a look at the different pattern for nodesjs, python, java,
dotnet in this snippet
https://playwright.dev/docs/api/class-page#page-get-by-text
So for an absolute beginner that wants to get started, snippets are guides
and they are mostly used the way it is written in the docs- using e.g
page.GetByText for a dotnet app will fail.
On Thu, Oct 31, 2024 at 4:30 PM Simon Knott ***@***.***>
wrote:
>
> https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/identifier-names#naming-conventions
> says that local variables should be in camelCase, and the snippets this
> PR updates are all assuming page to be a local variable. Am I missing
> something?
>
> —
> Reply to this email directly, view it on GitHub
> <#33382 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AMJJJTB7G4LHPSHT36SNRFTZ6JEHTAVCNFSM6AAAAABQ6M7A6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJQGE3TIOJYGI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
There was a problem hiding this comment.
Hello! Please revert the changes inside docs/src/api folder since they target the library where page is usually lowercase and the rest are guides which target Microsoft.Playwright.NUnit etc.
Also now a lot of methods use now mixed casing, some a bit of Page and some a bit of page. e.g. looking at input.md.
|
Alright, thanks for the explanation
…On Fri, Nov 1, 2024 at 9:46 AM Max Schmitt ***@***.***> wrote:
***@***.**** commented on this pull request.
Hello! Please revert the changes inside docs/src/api folder since they
target the library where page is usually lowercase and the rest are guides
which target Microsoft.Playwright.NUnit etc.
Also now a lot of methods use now mixed casing, some a bit of Page and
some a bit of page. e.g. looking at input.md.
—
Reply to this email directly, view it on GitHub
<#33382 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMJJJTBGQRZ7EKJJ5PTDGNDZ6M5X7AVCNFSM6AAAAABQ6M7A6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMBZG4YTSNRYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This is a dotnet docs update for Page.GetByText and age.GotoAsync