Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: expose expect matcher result on TestError #33151

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Oct 16, 2024

No description provided.

This comment has been minimized.

This comment has been minimized.

docs/src/test-reporter-api/class-testerror.md Show resolved Hide resolved
docs/src/test-reporter-api/class-testerror.md Show resolved Hide resolved
packages/html-reporter/src/testResultView.tsx Outdated Show resolved Hide resolved
packages/html-reporter/src/types.ts Outdated Show resolved Hide resolved
@@ -33,6 +33,7 @@ export function matcherHint(state: ExpectMatcherState, locator: Locator | undefi

export type MatcherResult<E, A> = {
name: string;
shortMessage?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like in the context of Matcher result, message is the short message.

packages/playwright/src/reporters/base.ts Outdated Show resolved Hide resolved
packages/playwright/src/util.ts Show resolved Hide resolved

This comment has been minimized.

@yury-s yury-s changed the title chore(html): expose expect matcher result on TestError chore: expose expect matcher result on TestError Oct 17, 2024

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

2 flaky ⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:87:5 › mobile viewport › should support window.orientation emulation @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:53:14 › page screenshot › should work with a mobile viewport and clip @webkit-ubuntu-22.04-node18

36003 passed, 624 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants