Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trace-viewer) add request urls for actions initiated via APIRequestContext #31534

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

ryanrosello-og
Copy link
Contributor

Improve action list UX by adding request urls for APIRequestContext actions

Currently the action list does not provide any information about the request urls for APIRequestContext actions. This makes it difficult to understand what the action is doing and would require the user to double click on the action to see the request url in the action details.

It would be advantageous to include the request url in the action list so that the user can quickly understand what the action is doing without having to double click on the action.

Note that this information is already exposed in the HTML report, so this change would only be for the action list in the Trace Viewer.

Snag_149cc729

Changes made

Add the request url to the action list for APIRequestContext actions (without the baseURL). When user hovers over the url, they can see the full url.

2024-07-02_21-12-50

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Test results for "tests 1"

1 failed
❌ [playwright-test] › reporter-html.spec.ts:390:5 › created › should use different path if attachments base url option is provided

8 flaky ⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-page] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects

28416 passed, 653 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit e36ebb6 into microsoft:main Jul 4, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants