Fixed searchid bug, added unit tests, improved main readme #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
777arc
changed the title
srijan55
reviewed
Aug 29, 2024
srijan55
reviewed
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was due to a breaking change in titiler-pgstac where the MosaicTilerFactory "info" endpoint was moved outside the class and into its own extension (called searchInfoExtension) and the fix was adding
extensions=[ searchInfoExtension()]toMosaicTilerFactory.I also added a unit test to test hitting
mosaic/{searchId}/infowith both a good and bad searchId, and I also added some other unit tests which I was using during debugging before I solved the bug, and figured it couldn't hurt to have more coverage.Btw I think the github actions are failing because my branch is on my fork, and it isn't able to get access to the secrets.AZURITE_ACCOUNT_KEY, I even tried adding the key to my forked repo but it doesnt work. "With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository". Adding me as a collaborator might fix it.Fixed, check out my change to the PR pipeline