Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cohort sync scheduled task to fail silently when auth_oidc is not configured #2709

Open
wants to merge 1 commit into
base: MOODLE_403_STABLE
Choose a base branch
from
Open

Allow cohort sync scheduled task to fail silently when auth_oidc is not configured #2709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions local/o365/classes/task/cohortsync.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

namespace local_o365\task;

use core\exception\moodle_exception;
use core\task\scheduled_task;
use local_o365\feature\cohortsync\main;
use local_o365\utils;
Expand All @@ -48,8 +49,14 @@ public function get_name(): string {
* @return bool
*/
public function execute(): bool {
$graphclient = main::get_unified_api(__METHOD__);
if (empty($graphclient)) {
try {
$graphclient = main::get_unified_api(__METHOD__);
if (empty($graphclient)) {
utils::mtrace("Failed to get Graph API client. Exiting.", 1);

return true;
}
} catch (moodle_exception $e) {
utils::mtrace("Failed to get Graph API client. Exiting.", 1);

return true;
Expand Down