release: fix federated auth #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One "funny" quirk of GitHub Actions is that some of their YAML constructs that users _assume_ to be cumulative, are not. One example is the `permissions` block: Most readers will assume that the following YAML will combine `contents` and `id-token` permissions: permissions: id-token: write jobs: my-job: permissions: contents: write However, that is not the case! The inner `permissions` block completely negates the outer `permissions` block. So let's just repeat ourselves to force GitHub Actions to understand which permissions we need. Signed-off-by: Johannes Schindelin <[email protected]>
derrickstolee
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One "funny" quirk of GitHub Actions is that some of their YAML constructs that users assume to be cumulative, are not. One example is the
permissionsblock: Most readers will assume that the following YAML will combinecontentsandid-tokenpermissions:However, that is not the case! The inner
permissionsblock completely negates the outerpermissionsblock. This can be seen in all its glory here. With this commit, the bug is fixed.