feat:(react-nav-preview) Builds out App Item #32103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
Mitch-At-Work
requested changes
Jul 26, 2024
packages/react-components/react-nav-preview/library/etc/react-nav-preview.api.md
Outdated
Show resolved
Hide resolved
packages/react-components/react-nav-preview/library/src/components/AppItem/AppItem.types.ts
Show resolved
Hide resolved
...react-components/react-nav-preview/library/src/components/AppItem/useAppItemStyles.styles.ts
Outdated
Show resolved
Hide resolved
...react-components/react-nav-preview/library/src/components/AppItem/useAppItemStyles.styles.ts
Show resolved
Hide resolved
...react-components/react-nav-preview/library/src/components/AppItem/useAppItemStyles.styles.ts
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
Mitch-At-Work
approved these changes
Jul 26, 2024
sopranopillow
approved these changes
Jul 26, 2024
change/@fluentui-react-nav-preview-e27acb8a-15b9-4611-b2dd-0f2731ee5e63.json
Outdated
Show resolved
Hide resolved
packages/react-components/react-nav-preview/stories/src/AppItem/AppItemDefault.stories.tsx
Show resolved
Hide resolved
packages/react-components/react-nav-preview/stories/src/NavDrawer/NavDrawerSize.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-nav-preview/stories/src/NavDrawer/NavDrawerSize.stories.tsx
Outdated
Show resolved
Hide resolved
…av/build-out-app-node-static
lekoulekou
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds out the AppItem. It is very similair to a NavItem, but does not have a selected state. It is intended to link the user out to some informational/salesy page.
We will fast follow with the static variant that does not contain link semantics, behavior or styling.
Added a bunch of test logic to the size story.
Picture from spec for reference
Picture in use
Ladders to #26649