Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

fix graddle conflict #601

Merged
merged 1 commit into from
Apr 14, 2020
Merged

fix graddle conflict #601

merged 1 commit into from
Apr 14, 2020

Conversation

nitrique
Copy link
Contributor

Fix bug on #600

@phyr0s
Copy link
Contributor

phyr0s commented Apr 1, 2020

Works fine

@GusLAN
Copy link

GusLAN commented Apr 8, 2020

works perfectly for me, thanks!

@Krasavinigor
Copy link
Contributor

Krasavinigor commented Apr 13, 2020

Hello @nitrique!
Sorry for the delay.
Thank you for contributing. You've done good and useful job=)
I reproduced error, but your fix doesn't work for me
Steps:

  1. Add cordova-plugin-firebase-dynamiclinks. Changed classpath 'com.google.gms:google-services:3.3.0' version to 4.2.0 for reproduction of this issue. For classpath 'com.google.gms:google-services:4.3.3' all works good.
  2. Add cordova-plugin-code-push
  3. Run command cordova build android

My project:

Archive.zip

@phyr0s
Copy link
Contributor

phyr0s commented Apr 13, 2020

Hello @Krasavinigor. Adjust the Firebase plugin to upgrade to google-services 4.3.3 instead 4.2.0 and will work

The problem with the phonegap-push-plugin is fixed with that change, not necessary to do nothing more.

@Krasavinigor
Copy link
Contributor

Thanks @videmort.
So, I'm going to close this PR.

@phyr0s
Copy link
Contributor

phyr0s commented Apr 13, 2020

@Krasavinigor this pr should be merged, not closed. It fixed several compile problems with a lot of cordova plugins. If you use that plugin cordova-plugin-firebase-dynamiclink changing only the google play version will not work due nimbusds or with phonegap-push-plugin it's same.
Skip net.minidev:json-smart in gradle to compile.

Merge and create new release with that fix if you close this, the issue will be forever.

The issue --> #600

And the log is very very clear

`Dependency failing: com.nimbusds:nimbus-jose-jwt:5.1 -> net.minidev:json-smart@[1.3.1,2.3], but json-smart version was 2
.3.

The following dependencies are project dependencies that are direct or have transitive dependencies that lead to the art
ifact with the issue.
-- Project 'app' depends onto net.minidev:json-smart@{strictly 2.3}
-- Project 'app' depends onto com.nimbusds:nimbus-jose-jwt@{strictly 5.1}
-- Project 'app' depends onto com.nimbusds:[email protected]`

And thanks @nitrique for the quick fix. We hope that Microsoft add this asap. People are using the previous code-push version due this issue.

@arturobernalg
Copy link

+1

@arturobernalg
Copy link

works perfectly, thanks!

Copy link
Contributor

@alexandergoncharov-zz alexandergoncharov-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandergoncharov-zz
Copy link
Contributor

Hi all,
Thanks for contributing!

@videmort , thanks for providing additional details!

We've tested it and haven't found any issues.

@dpogue
Copy link
Contributor

dpogue commented May 25, 2020

This change causes Android apps to crash when downloading an update, due to missing classes. See #613

@ludufre
Copy link

ludufre commented Sep 28, 2020

Yeah, I have the same #613 issue, because of this changes.

With latest versions 1.13.1 I have to change compile('com.nimbusds:nimbus-jose-jwt:5.1') { exclude group: "net.minidev", module: "json-smart" } to compile 'com.nimbusds:nimbus-jose-jwt:5.1'

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants