Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signal propagation to child processes for PythonScriptV0 task #19938

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add signal propagation to child processes for PythonScriptV0 task #19938

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7087fe6
Add signal propagation to child processes
ivanduplenskikh May 31, 2024
0c3fd13
Merge branch 'master' into users/v-ivandu/pythonscriptv0-signal-propa…
ivanduplenskikh Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Tasks/PythonScriptV0/pythonscript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ export async function pythonScript(parameters: Readonly<TaskParameters>): Promis
python.line(parameters.arguments);
}

['SIGINT', 'SIGTERM'].forEach((signal) => {
process.on(signal, () => {
python.killChildProcess(signal as NodeJS.Signals);
});
});

// Run the script
// Use `any` to work around what I suspect are bugs with `IExecOptions`'s type annotations:
// - optional fields need to be typed as optional
Expand Down
Loading