-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add application insights connection string support - APPLICATIONINSIGHTS_CONNECTION_STRING #19855
base: master
Are you sure you want to change the base?
Add application insights connection string support - APPLICATIONINSIGHTS_CONNECTION_STRING #19855
Conversation
…s-connection-string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the Task.json as mentioned?
Sure, I just did, and updated issue template too. Feel free to point any mistake I would have made in the process of course! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me from the Function side of things. Thanks for the contribution.
…s-connection-string # Conflicts: # Tasks/AzureRmWebAppDeploymentV3/task.json # Tasks/AzureRmWebAppDeploymentV3/task.loc.json # Tasks/AzureRmWebAppDeploymentV4/task.json # Tasks/AzureRmWebAppDeploymentV4/task.loc.json # _generated/AzureRmWebAppDeploymentV3.versionmap.txt # _generated/AzureRmWebAppDeploymentV3/task.json # _generated/AzureRmWebAppDeploymentV3/task.loc.json # _generated/AzureRmWebAppDeploymentV3_Node20/task.json # _generated/AzureRmWebAppDeploymentV3_Node20/task.loc.json # _generated/AzureRmWebAppDeploymentV4.versionmap.txt # _generated/AzureRmWebAppDeploymentV4/task.json # _generated/AzureRmWebAppDeploymentV4/task.loc.json # _generated/AzureRmWebAppDeploymentV4_Node20/task.json # _generated/AzureRmWebAppDeploymentV4_Node20/task.loc.json
hi @jvano, @dannysongg, @manolerazvan, @patelchandni, Could you guide me on how to have this pr be reviewed and integrated ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…s-connection-string
Thanks @jvano, @manolerazvan ! @dannysongg, @patelchandni, could you please take a look ? |
Hello @Greybird I think in this instance Joaquin and Danny are part of the Web Apps task team and Chandni and I are part of the Functions team so just one approval is probably needed from each team. |
@FinVamp1, you are right, sorry, I suppose there is nothing left for me to do currently, as checks now have to run, which I believe depends on some validation on Microsoft side ? Thanks again for your guidance with the process ! |
Hello, I updated sprint to 241. |
74707d2
to
7070e69
Compare
I updated sprint to 242 |
@v-schhabra sorry to ping you, but I saw a rebase on master from you, can you provide guidance ? Every option to make the PR more mergeable in the documentation is not possible for me (cannot label, cannot add a reviewer, and I already linked an issue, but I cannot add it to the PR.) |
Task names:
Description:
The PR adds support for adding release annotations when the now recommended APPLICATIONINSIGHTS_CONNECTION_STRING setting is used on Azure, rather than the APPINSIGHTS_INSTRUMENTATIONKEY, for all tasks supporting this feature.
Documentation changes required:
I don't think so.
Added unit tests:
No.
I did not find tests for release annotation based on InstrumentationKey.
I had a hard time figuring how to add unit tests for the connection string use case, and tests seem to come from another zone of the code.
Happy to get guidance on the matter however.
Attached related issue:
#18796 (closed due to being stale, probably needs reopening)
Checklist: