Added date to deprecation warnings for DownloadPackageV0, NuGetInstal…

…lerV0, and NuGetRestoreV1 (#19078) * Added date to deprecation warnings for DownloadPackageV0, NuGetInstallerV0, and NuGetRestoreV1 * Modified L0 tests to accept new deprecation message * Added removalDate and updated patches * Reverted changes to DownloadPackageV0's package-lock.json file * Clearer deprecation message --------- Co-authored-by: Abby Powell (from Dev Box) <[email protected]>
microsoft · Oct 10, 2023 · 4a4464b · 4a4464b
1 parent 3c052b8
commit 4a4464b
Show file tree

Hide file tree

Showing 10 changed files with 16 additions and 16 deletions.
diff --git a/Tasks/DownloadPackageV0/download.ts b/Tasks/DownloadPackageV0/download.ts
@@ -13,7 +13,7 @@ import { WebApi } from 'azure-devops-node-api';
 tl.setResourcePath(path.join(__dirname, 'task.json'));
 
 async function main(): Promise<void> {
-	tl.warning("This task will be deprecated soon. Please switch to using DownloadPackage@1");
+	tl.warning("This task is deprecated. Builds that use it will break on 11-27-2023. Please switch to using DownloadPackage@1 as soon as possible.");
 	var feed = getProjectAndFeedIdFromInputParam("feed");
 	if(feed.projectId) {
 		throw new Error(tl.loc("UnsupportedProjectScopedFeeds"));

diff --git a/Tasks/DownloadPackageV0/task.json b/Tasks/DownloadPackageV0/task.json
@@ -10,12 +10,12 @@
     "version": {
         "Major": 0,
         "Minor": 229,
-        "Patch": 1
+        "Patch": 2
     },
     "demands": [],
     "minimumAgentVersion": "2.144.0",
     "deprecated": true,
-    "removalDate": "2024-04-22",
+    "removalDate": "2023-11-27",
     "inputs": [
         {
             "name": "feed",

diff --git a/Tasks/DownloadPackageV0/task.loc.json b/Tasks/DownloadPackageV0/task.loc.json
@@ -10,12 +10,12 @@
   "version": {
     "Major": 0,
     "Minor": 229,
-    "Patch": 1
+    "Patch": 2
   },
   "demands": [],
   "minimumAgentVersion": "2.144.0",
   "deprecated": true,
-  "removalDate": "2024-04-22",
+  "removalDate": "2023-11-27",
   "inputs": [
     {
       "name": "feed",

diff --git a/Tasks/NuGetInstallerV0/Tests/L0.ts b/Tasks/NuGetInstallerV0/Tests/L0.ts
@@ -33,7 +33,7 @@ describe('NuGetInstaller Suite', function () {
         assert(tr.stdout.indexOf('credProviderPath = ') >= 0, "should have found credential provider path");
         assert(tr.succeeded, 'should have succeeded');
         assert(tr.invokedToolCount == 1, 'should have run NuGet');
-        assert.equal(tr.warningIssues[0], 'This task will be deprecated soon', "should have deprecation warning");
+        assert.equal(tr.warningIssues[0], "This task is deprecated. Builds that use it will break on 11-27-2023. Please switch to using NuGetCommand@2's 'restore' option as soon as possible.", "should have deprecation warning");
         assert.equal(tr.errorIssues.length, 0, "should have no errors");
         done();
     }).timeout(20000);

diff --git a/Tasks/NuGetInstallerV0/nugetinstaller.ts b/Tasks/NuGetInstallerV0/nugetinstaller.ts
@@ -24,7 +24,7 @@ class RestoreOptions implements INuGetCommandOptions {
 }
 
 async function main(): Promise<void> {
-    tl.warning("This task will be deprecated soon");
+    tl.warning("This task is deprecated. Builds that use it will break on 11-27-2023. Please switch to using NuGetCommand@2's 'restore' option as soon as possible.");
     let packagingLocation: pkgLocationUtils.PackagingLocation;
     try {
         packagingLocation = await pkgLocationUtils.getPackagingUris(pkgLocationUtils.ProtocolType.NuGet);

diff --git a/Tasks/NuGetInstallerV0/task.json b/Tasks/NuGetInstallerV0/task.json
@@ -10,15 +10,15 @@
     "version": {
         "Major": 0,
         "Minor": 229,
-        "Patch": 0
+        "Patch": 1
     },
     "runsOn": [
         "Agent",
         "DeploymentGroup"
     ],
     "minimumAgentVersion": "2.115.0",
     "deprecated": true,
-    "removalDate": "2024-04-22",
+    "removalDate": "2023-11-27",
     "groups": [
         {
             "name": "advanced",

diff --git a/Tasks/NuGetInstallerV0/task.loc.json b/Tasks/NuGetInstallerV0/task.loc.json
@@ -10,15 +10,15 @@
   "version": {
     "Major": 0,
     "Minor": 229,
-    "Patch": 0
+    "Patch": 1
   },
   "runsOn": [
     "Agent",
     "DeploymentGroup"
   ],
   "minimumAgentVersion": "2.115.0",
   "deprecated": true,
-  "removalDate": "2024-04-22",
+  "removalDate": "2023-11-27",
   "groups": [
     {
       "name": "advanced",

diff --git a/Tasks/NuGetRestoreV1/nugetinstaller.ts b/Tasks/NuGetRestoreV1/nugetinstaller.ts
@@ -30,7 +30,7 @@ class RestoreOptions implements INuGetCommandOptions {
 }
 
 async function main(): Promise<void> {
-    tl.warning("This task will be deprecated soon. Please switch to using NuGetCommand@2's 'restore' option");
+    tl.warning("This task is deprecated. Builds that use it will break on 11-27-2023. Please switch to using NuGetCommand@2's 'restore' option as soon as possible.");
     let packagingLocation: pkgLocationUtils.PackagingLocation;
     try {
         tl.debug("getting the uris");

diff --git a/Tasks/NuGetRestoreV1/task.json b/Tasks/NuGetRestoreV1/task.json
@@ -10,15 +10,15 @@
     "version": {
         "Major": 1,
         "Minor": 229,
-        "Patch": 3
+        "Patch": 4
     },
     "runsOn": [
         "Agent",
         "DeploymentGroup"
     ],
     "minimumAgentVersion": "2.144.0",
     "deprecated": true,
-    "removalDate": "2024-04-22",
+    "removalDate": "2023-11-27",
     "groups": [
         {
             "name": "advanced",

diff --git a/Tasks/NuGetRestoreV1/task.loc.json b/Tasks/NuGetRestoreV1/task.loc.json
@@ -10,15 +10,15 @@
   "version": {
     "Major": 1,
     "Minor": 229,
-    "Patch": 3
+    "Patch": 4
   },
   "runsOn": [
     "Agent",
     "DeploymentGroup"
   ],
   "minimumAgentVersion": "2.144.0",
   "deprecated": true,
-  "removalDate": "2024-04-22",
+  "removalDate": "2023-11-27",
   "groups": [
     {
       "name": "advanced",