Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes for revision of paper #56

Merged
merged 9 commits into from
Dec 22, 2024
Merged

Minor changes for revision of paper #56

merged 9 commits into from
Dec 22, 2024

Conversation

wesselb
Copy link
Contributor

@wesselb wesselb commented Dec 12, 2024

Add minor changes to synchronise the code with the revision of the paper.

  • Mention wave model.
  • Update title and arXiv citation.
  • Expose timestep of the model and make configurable.
  • Expose level aggregation stabilisation tweak.
  • Add additional fine-tuning advice.
  • Test that model runs under DDP wrapping.
  • Add the ability to save and load batches.

@wesselb wesselb self-assigned this Dec 12, 2024
@wesselb wesselb requested a review from megstanley December 12, 2024 12:48
Copy link
Collaborator

@megstanley megstanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wesselb wesselb merged commit e6aeac6 into main Dec 22, 2024
6 checks passed
@wesselb wesselb deleted the wesselb/paper-revision branch December 22, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants