Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scenario1_BasicFunctionality.xaml.cs #965

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LanceMcCarthy
Copy link

This fixes the problem discussed in this documentation fix MicrosoftDocs/windows-dev-docs#681

The documentation has been updated, this sample should also be updated with the fix

@oldnewthing oldnewthing force-pushed the master branch 6 times, most recently from 2239d7f to 9bf6501 Compare December 20, 2019 22:40
@oldnewthing
Copy link
Member

This isn't quite right, because you don't have to start the software trigger. The hardware trigger still works (and is recommended since it uses less power). Will need to add checkbox to select whether to scan continuously or to scan only when hardware trigger is pressed.

@LanceMcCarthy
Copy link
Author

Thanks Raymond. Should I just add that to my branch? I can add the checkbox to enable/disable software scanning so we can keep it in this PR to maintain context.

@oldnewthing
Copy link
Member

I'll add this to the list of things for me to do (it's sort of already on the list, since it's an open PR). I'll need to port the sample to C++/WinRT first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StartSoftwareTiggerAsync() needs to be called
2 participants