Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vp9 to MediaTranscoding sample #1416

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

drewbatgit
Copy link

Description

Name of sample: MediaTranscoding

I added VP9 codec as an option for transcoding. I copied the existing pattern for other codecs (e.g. mp4)

Testing

I'm doing ad hoc testing and, at the time I'm creating the draft PR, the VP9 transcoding is failing gracefully.

Type of change

  • Bug fix
  • [ x] New feature
  • Porting to new language

Supported platforms

Minimum OS version: (example: 18362)

  • All UWP platforms
  • [x ] Desktop
  • Holographic
  • IoT
  • Xbox
  • 10X

Supported languages

  • [x ] C#
  • C++/WinRT

Additional remarks

I'm updating the C++/CX sample, despite the supported languages instructions above. I'll consult with the feature team about this before taking the PR out of draft.

@Zofware
Copy link

Zofware commented Oct 27, 2024

@drewbatgit does transcoding to VP9 and AV1 still work for you? I found your PR because I'm unable to get VP9 or AV1 transcoding working in C# on Win11 24H2. The encoding seems to progress successfully but at the very end it throws this exception:

WinRT originate error - 0xC00D4A45 : 'Sink could not create valid output file because required headers were not provided to the sink.'.

@Zofware
Copy link

Zofware commented Oct 27, 2024

I tried both the C# and C++ versions of the MediaTranscoding sample and both of them throw the same exception when modified to use CreateAv1 or CreateVp9 instead of CreateMp4 unfortunately. This is on a Surface Pro 7+ running Win11 24H2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants