Superbenchmark executor: online inference config file and custom repo link #369
Conversation
| /// <summary> | ||
| /// Link to the superbench repo. | ||
| /// </summary> | ||
| public string RepositoryLink |
There was a problem hiding this comment.
Do we need to change the repository link? Even if we need to support extra config?
| string configFileName = Path.GetFileName(configFileUri.AbsolutePath); | ||
| string configFullPath = this.PlatformSpecifics.Combine(this.SuperBenchmarkDirectory, configFileName); | ||
|
|
||
| using (var client = new HttpClient()) |
There was a problem hiding this comment.
Let's not add un-unit testable code here.
There was a problem hiding this comment.
Are cmd line based methods preferred? like wget or curl?
|
Could we do this instead: you are allowed to use extra dependency (for example git clone) in the profile, and you give it a package name. You then could reference the file you cloned by path. |
so it's not just about inference config file. some people have created their own SB benchmarks (in their own repo) and want to run those. The official one do not have these benchmarks. That's why I added a parameter for repoLink |
Added support for