Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getNonNullableType application in checkIdentifier #60523

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove getNonNullableType application in checkIdentifier #60523

wants to merge 1 commit into from

Conversation

bgenia
Copy link

@bgenia bgenia commented Nov 17, 2024

Fixes #60514

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Nov 17, 2024
@Andarist
Copy link
Contributor

Out of pure curiosity - do you know why this doesn't regress the tests introduced by #50092 ? :p

@jakebailey
Copy link
Member

That PR's test didn't seem to enable strict mode...

@bgenia
Copy link
Author

bgenia commented Nov 18, 2024

Enabling strict mode in that test causes undefined to appear in the baselines, but everything still seems correct. I also tried applying these changes directly to that PR to ensure that other PRs didn't affect it, and the result is the same, both with and without strict null checks. I guess this wasn't needed? At least for that test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Status: Not started
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird behaviour with an "evolving any" and a non-null assertion operator
4 participants
@bgenia @Andarist @jakebailey @typescript-bot