Try avoid slice-ing in `getPathFromPathComponents`. #60371

DanielRosenwasser · 2024-10-29T21:26:27Z

No description provided.

DanielRosenwasser · 2024-10-29T21:28:58Z

typescript-bot · 2024-10-29T21:29:02Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

typescript-bot · 2024-10-29T22:17:59Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,914k (± 0.74%)}	_{196,202k (± 0.26%)}	_~	_195,252k	_196,679k	_{p=0.689 n=6}
_{Parse Time}	_{1.98s (± 1.40%)}	_{1.99s (± 0.74%)}	_~	_1.97s	_2.00s	_{p=0.677 n=6}
_{Bind Time}	_{1.07s (± 1.63%)}	_{1.08s (± 1.61%)}	_~	_1.06s	_1.11s	_{p=0.373 n=6}
_{Check Time}	_{14.57s (± 0.54%)}	_{14.60s (± 0.55%)}	_~	_14.52s	_14.70s	_{p=0.810 n=6}
_{Emit Time}	_{4.12s (± 1.29%)}	_{4.24s (± 4.55%)}	_~	_4.06s	_4.49s	_{p=0.422 n=6}
_{Total Time}	_{21.75s (± 0.40%)}	_{21.91s (± 1.16%)}	_~	_21.65s	_22.29s	_{p=0.378 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,886	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,813k (± 0.00%)}	_{1,224,853k (± 0.00%)}	_~	_1,224,777k	_1,224,907k	_{p=0.173 n=6}
_{Parse Time}	_{8.06s (± 1.30%)}	_{8.10s (± 0.86%)}	_~	_8.00s	_8.18s	_{p=0.521 n=6}
_{Bind Time}	_{2.28s (± 1.62%)}	_{2.27s (± 0.72%)}	_~	_2.25s	_2.30s	_{p=0.872 n=6}
_{Check Time}	_{37.92s (± 0.38%)}	_{37.89s (± 0.30%)}	_~	_37.70s	_38.00s	_{p=0.688 n=6}
_{Emit Time}	_{18.31s (± 0.86%)}	_{18.33s (± 0.37%)}	_~	_18.23s	_18.41s	_{p=0.872 n=6}
_{Total Time}	_{66.56s (± 0.38%)}	_{66.59s (± 0.21%)}	_~	_66.38s	_66.75s	_{p=0.688 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,494,874	_2,494,874	_~	_~	_~	_{p=1.000 n=6}
_Types	_908,486	_908,486	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,307,724k (± 0.00%)}	_{2,307,731k (± 0.00%)}	_~	_2,307,619k	_2,307,842k	_{p=0.689 n=6}
_{Parse Time}	_{11.13s (± 0.69%)}	_{11.23s (± 0.28%)}	_{+0.10s (+ 0.91%)}	_11.19s	_11.27s	_{p=0.013 n=6}
_{Bind Time}	_{2.63s (± 0.79%)}	_{2.61s (± 1.22%)}	_~	_2.56s	_2.65s	_{p=0.466 n=6}
_{Check Time}	_{91.01s (± 1.96%)}	_{91.49s (± 2.40%)}	_~	_89.84s	_95.62s	_{p=0.471 n=6}
_{Emit Time}	_{0.35s (± 1.46%)}	_{0.35s (± 2.14%)}	_~	_0.34s	_0.36s	_{p=0.784 n=6}
_{Total Time}	_{105.12s (± 1.66%)}	_{105.68s (± 2.08%)}	_~	_104.09s	_109.80s	_{p=0.471 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,087	_1,258,088	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,235	_266,235	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,905,772k (±12.85%)}	_{3,026,224k (± 9.74%)}	_~	_2,423,905k	_3,147,298k	_{p=0.936 n=6}
_{Parse Time}	_{6.54s (± 2.05%)}	_{6.58s (± 1.24%)}	_~	_6.42s	_6.65s	_{p=0.936 n=6}
_{Bind Time}	_{2.34s (± 1.96%)}	_{2.35s (± 1.06%)}	_~	_2.32s	_2.38s	_{p=0.688 n=6}
_{Check Time}	_{43.17s (± 0.30%)}	_{43.12s (± 0.45%)}	_~	_42.94s	_43.41s	_{p=0.630 n=6}
_{Emit Time}	_{3.60s (± 2.44%)}	_{3.58s (± 1.65%)}	_~	_3.53s	_3.68s	_{p=0.810 n=6}
_{Total Time}	_{55.67s (± 0.34%)}	_{55.62s (± 0.31%)}	_~	_55.42s	_55.88s	_{p=0.575 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,087	_1,258,088	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,235	_266,235	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,496,810k (± 0.02%)}	_{2,496,292k (± 0.02%)}	_~	_2,495,393k	_2,497,112k	_{p=0.078 n=6}
_{Parse Time}	_{5.41s (± 0.77%)}	_{5.40s (± 0.99%)}	_~	_5.33s	_5.48s	_{p=0.873 n=6}
_{Bind Time}	_{1.74s (± 0.60%)}	_{1.74s (± 0.51%)}	_~	_1.73s	_1.75s	_{p=0.452 n=6}
_{Check Time}	_{35.83s (± 0.29%)}	_{35.85s (± 0.24%)}	_~	_35.78s	_35.99s	_{p=0.936 n=6}
_{Emit Time}	_{3.05s (± 1.29%)}	_{3.03s (± 1.12%)}	_~	_2.99s	_3.09s	_{p=0.575 n=6}
_{Total Time}	_{46.01s (± 0.27%)}	_{46.02s (± 0.10%)}	_~	_45.94s	_46.07s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,754	_261,755	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,477	_106,477	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{438,826k (± 0.01%)}	_{438,831k (± 0.01%)}	_~	_438,796k	_438,885k	_{p=0.936 n=6}
_{Parse Time}	_{3.53s (± 0.70%)}	_{3.53s (± 0.70%)}	_~	_3.49s	_3.56s	_{p=1.000 n=6}
_{Bind Time}	_{1.32s (± 1.12%)}	_{1.30s (± 1.16%)}	_~	_1.28s	_1.32s	_{p=0.160 n=6}
_{Check Time}	_{18.96s (± 0.23%)}	_{18.95s (± 0.38%)}	_~	_18.85s	_19.04s	_{p=0.936 n=6}
_{Emit Time}	_{1.55s (± 1.38%)}	_{1.54s (± 0.97%)}	_~	_1.53s	_1.56s	_{p=0.564 n=6}
_{Total Time}	_{25.36s (± 0.20%)}	_{25.34s (± 0.26%)}	_~	_25.24s	_25.41s	_{p=0.808 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,919	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,126k (± 0.02%)}	_{371,112k (± 0.01%)}	_~	_371,039k	_371,165k	_{p=0.936 n=6}
_{Parse Time}	_{3.64s (± 1.06%)}	_{3.59s (± 0.79%)}	_{-0.05s (- 1.37%)}	_3.54s	_3.62s	_{p=0.045 n=6}
_{Bind Time}	_{1.97s (± 0.75%)}	_{1.96s (± 1.15%)}	_~	_1.92s	_1.98s	_{p=0.368 n=6}
_{Check Time}	_{20.34s (± 0.41%)}	_{20.36s (± 0.42%)}	_~	_20.23s	_20.44s	_{p=0.689 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.96s (± 0.19%)}	_{25.90s (± 0.24%)}	_~	_25.81s	_25.98s	_{p=0.145 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,129,129	_3,129,129	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,078,592	_1,078,592	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,221,523k (± 0.02%)}	_{3,221,171k (± 0.01%)}	_~	_3,220,589k	_3,221,571k	_{p=0.471 n=6}
_{Parse Time}	_{14.05s (± 0.37%)}	_{14.12s (± 0.31%)}	_~	_14.07s	_14.17s	_{p=0.102 n=6}
_{Bind Time}	_{4.45s (± 2.39%)}	_{4.46s (± 2.29%)}	_~	_4.40s	_4.67s	_{p=0.512 n=6}
_{Check Time}	_{85.05s (± 1.56%)}	_{85.59s (± 1.63%)}	_~	_84.66s	_87.64s	_{p=0.748 n=6}
_{Emit Time}	_{26.53s (± 6.87%)}	_{26.40s (± 6.92%)}	_~	_22.69s	_27.38s	_{p=0.575 n=6}
_{Total Time}	_{130.07s (± 1.76%)}	_{130.57s (± 1.92%)}	_~	_126.09s	_133.26s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_286,866	_286,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_116,245	_116,245	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{437,915k (± 0.04%)}	_{437,908k (± 0.02%)}	_~	_437,782k	_437,985k	_{p=0.689 n=6}
_{Parse Time}	_{4.03s (± 0.62%)}	_{4.03s (± 1.09%)}	_~	_3.96s	_4.09s	_{p=1.000 n=6}
_{Bind Time}	_{1.75s (± 1.34%)}	_{1.74s (± 1.65%)}	_~	_1.70s	_1.79s	_{p=1.000 n=6}
_{Check Time}	_{18.57s (± 0.56%)}	_{18.53s (± 0.32%)}	_~	_18.44s	_18.61s	_{p=0.574 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.35s (± 0.44%)}	_{24.30s (± 0.40%)}	_~	_24.15s	_24.42s	_{p=0.630 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_543,130	_543,130	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,889	_181,889	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{485,480k (± 0.01%)}	_{485,450k (± 0.01%)}	_~	_485,356k	_485,514k	_{p=0.375 n=6}
_{Parse Time}	_{3.36s (± 0.92%)}	_{3.37s (± 0.89%)}	_~	_3.32s	_3.41s	_{p=0.494 n=6}
_{Bind Time}	_{1.18s (± 1.20%)}	_{1.17s (± 1.14%)}	_~	_1.15s	_1.19s	_{p=0.190 n=6}
_{Check Time}	_{19.20s (± 0.52%)}	_{19.15s (± 0.22%)}	_~	_19.09s	_19.20s	_{p=0.336 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{23.74s (± 0.51%)}	_{23.69s (± 0.22%)}	_~	_23.63s	_23.75s	_{p=0.229 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,980ms (±10.25%)}	_{2,876ms (± 0.35%)}	_~	_2,860ms	_2,886ms	_{p=0.298 n=6}
_{Req 2 - geterr}	_{7,413ms (±10.64%)}	_{7,384ms (±10.51%)}	_~	_6,389ms	_8,005ms	_{p=0.810 n=6}
_{Req 3 - references}	_{398ms (± 7.95%)}	_{405ms (± 7.34%)}	_~	_345ms	_423ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{328ms (±10.35%)}	_{358ms (± 2.96%)}	_~	_341ms	_369ms	_{p=0.093 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{117ms (±10.41%)}	_{119ms (± 2.98%)}	_~	_117ms	_126ms	_{p=0.809 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,423ms (± 1.16%)}	_{2,456ms (± 0.92%)}	_{+33ms (+ 1.36%)}	_2,415ms	_2,475ms	_{p=0.045 n=6}
_{Req 2 - geterr}	_{3,977ms (± 0.17%)}	_{3,976ms (± 0.17%)}	_~	_3,966ms	_3,987ms	_{p=0.810 n=6}
_{Req 3 - references}	_{280ms (± 1.25%)}	_{282ms (± 0.94%)}	_~	_277ms	_284ms	_{p=0.324 n=6}
_{Req 4 - navto}	_{226ms (± 0.18%)}	_{226ms (± 0.28%)}	_~	_225ms	_227ms	_{p=0.673 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (± 7.31%)}	_{84ms (± 5.10%)}	_{🔻+6ms (+ 7.73%)}	_75ms	_86ms	_{p=0.034 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{6,505ms (± 0.48%)}	_{6,545ms (± 0.91%)}	_~	_6,460ms	_6,640ms	_{p=0.149 n=6}
_{Req 2 - geterr}	_{1,438ms (± 9.58%)}	_{1,599ms (±10.32%)}	_~	_1,371ms	_1,717ms	_{p=0.199 n=6}
_{Req 3 - references}	_{117ms (± 8.20%)}	_{121ms (± 6.42%)}	_~	_106ms	_127ms	_{p=0.419 n=6}
_{Req 4 - navto}	_{593ms (± 2.49%)}	_{588ms (± 8.04%)}	_~	_492ms	_612ms	_{p=0.297 n=6}
_{Req 5 - completionInfo count}	_3,450	_3,450	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{1,293ms (± 1.37%)}	_{1,248ms (± 9.72%)}	_~	_1,006ms	_1,341ms	_{p=0.575 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{185.22ms (± 0.18%)}	_{185.18ms (± 0.18%)}	_~	_183.38ms	_187.83ms	_{p=0.233 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{289.97ms (± 0.28%)}	_{289.86ms (± 0.29%)}	_~	_282.93ms	_295.66ms	_{p=0.076 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{273.21ms (± 0.28%)}	_{272.98ms (± 0.31%)}	_{-0.22ms (- 0.08%)}	_266.17ms	_278.64ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{273.24ms (± 0.30%)}	_{273.14ms (± 0.30%)}	_{-0.11ms (- 0.04%)}	_266.31ms	_277.60ms	_{p=0.003 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

DanielRosenwasser added 2 commits October 29, 2024 21:24

Try adding a non-allocating path to getPathFromPathComponents.

73043ce

Drive-by replacement of substr with slice.

bb2ca84

typescript-bot assigned DanielRosenwasser Oct 29, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try avoid slice-ing in `getPathFromPathComponents`. #60371

Try avoid slice-ing in `getPathFromPathComponents`. #60371

DanielRosenwasser commented Oct 29, 2024

DanielRosenwasser commented Oct 29, 2024

typescript-bot commented Oct 29, 2024 •

edited

Loading

typescript-bot commented Oct 29, 2024

tsc

tsserver

startup

Try avoid slice-ing in getPathFromPathComponents. #60371

Are you sure you want to change the base?

Try avoid slice-ing in getPathFromPathComponents. #60371

Conversation

DanielRosenwasser commented Oct 29, 2024

DanielRosenwasser commented Oct 29, 2024

typescript-bot commented Oct 29, 2024 • edited Loading

typescript-bot commented Oct 29, 2024

tsc

tsserver

startup

Try avoid slice-ing in `getPathFromPathComponents`. #60371

Try avoid slice-ing in `getPathFromPathComponents`. #60371

typescript-bot commented Oct 29, 2024 •

edited

Loading