Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SampleBarChart to new Formatting Model Pane #102

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

ShereinDabbah
Copy link

No description provided.

Sherein Dabbah and others added 5 commits July 5, 2022 16:16
…ngSettingsService

Modify formatting settings to use formatting model utils service & Add strings localization
remove displayNames from capabilities
replace displayNameKey by DisplayName in FormattingSettings
package.json Outdated Show resolved Hide resolved
@ShereinDabbah ShereinDabbah requested review from AleksSavelev and removed request for gekeldaw January 2, 2023 08:13
@MulyukovAidar
Copy link
Contributor

will this ever be merged?

Sherein Dabbah and others added 18 commits February 20, 2023 16:53
Signed-off-by: Sherein Dabbah <[email protected]>
…d strings localization

Signed-off-by: Sherein Dabbah <[email protected]>
remove displayNames from capabilities
replace displayNameKey by DisplayName in FormattingSettings

Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
Signed-off-by: Sherein Dabbah <[email protected]>
package.json Show resolved Hide resolved
src/barChartSettingsModel.ts Show resolved Hide resolved
* populate colorSelector object categories formatting properties
* @param dataPoints
*/
populateColorSelector(dataPoints: BarChartDataPoint[]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the visual tightly bounded to the implementation of the formatting model. Is there any extendible pattern that could be used in case of multiple dynamic properties?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain more what do you mean by this comment

src/barChart.ts Outdated Show resolved Hide resolved
src/barChart.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants